pcp
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

[pcp] Windows: Fix Performance Counter for mem.cache.bytes (#43)

from [Diego Giagio] [Permanent Link][Original]
To: performancecopilot/pcp <pcp@xxxxxxxxxxxxxxxxxx>
Subject: [pcp] Windows: Fix Performance Counter for mem.cache.bytes (#43)
From: Diego Giagio <notifications@xxxxxxxxxx>
Date: Fri, 21 Aug 2015 09:17:15 -0700
Delivered-to: pcp@xxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha1; c=relaxed; d=github.com; h=from:reply-to:to:subject:mime-version:content-type:content-transfer-encoding:list-id:list-archive:list-post:list-unsubscribe; s=s20150108; bh=H5wEu/jJP567OSmvVTqSI8Y6Muk=; b=sWiCr8/M7FQrykYz 1I1vKr45LM6lWg+mrmNIJS6XOLFRYrrnXzx0qd0URymmgaCP1Z1RbYNlyztGX2ul EKp1Yyal8yboJtV7XOV83BtKmn7M2pQZoh5ZowtaRPxbi3dWj0PPfsO/Id+cu2uR 2lQW1BFnOvHd97ceNW7y9g4vi4A=
List-archive: https://github.com/performancecopilot/pcp
List-id: performancecopilot/pcp <pcp.performancecopilot.github.com>
List-post: <mailto:reply+00bd08b6c800f8daf10192976dd351590da042e3039f852592cf0000000111ef110b92a169ce061ab4aa@reply.github.com>
List-unsubscribe: <mailto:unsub+00bd08b6c800f8daf10192976dd351590da042e3039f852592cf0000000111ef110b92a169ce061ab4aa@reply.github.com>, <https://github.com/notifications/unsubscribe/AL0Itq3XK3gEkV7bxTea4oqD9jxOd7Lcks5op0aLgaJpZM4Fv_sJ>
Reply-to: performancecopilot/pcp <reply+00bd08b6c800f8daf10192976dd351590da042e3039f852592cf0000000111ef110b92a169ce061ab4aa@xxxxxxxxxxxxxxxx>

The mem.cache.bytes metric is collecting data from an incorrect Performance Counter: \Memory\Pages Faults/sec. This patch fixes that by pointing to \Memory\Cache Bytes. Also fixed the data types (U32 -> U64) and semantic interpretation (COUNTER -> INSTANT). For consistency, changed \Metric\Cache Bytes Peak data type (64 -> U64) as well.

You can view, comment on, or merge this pull request online at:

  https://github.com/performancecopilot/pcp/pull/43

Commit Summary

  • Windows: fix Performance Counter for mem.cache.bytes

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub.

[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Multi-archive Contexts in Reverse, Dave Brolley
Next by Date:  [Bug 1235556] RFE: Allow inclusion of derived metrics files, bugzilla
Previous by Thread:  Multi-archive Contexts in Reverse, Dave Brolley
Next by Thread:  Re: [pcp] Windows: Fix Performance Counter for mem.cache.bytes (#43), Nathan Scott
Indexes:  [Date] [Thread] [Top] [All Lists]