Nathan,
On 3/18/15 12:35 AM, Nathan Scott wrote:
----- Original Message -----
Nathan,
On 3/12/15 5:35 PM, Nathan Scott wrote:
No worries at all - let me know if help needed eg on the QA front, happy to
hack on that little mock testing python module in parallel.
Sure, if you have the time.
There's always time for QA. :) Attached is an initial pass at a mock module
to help exercising this, hopefully its a useful start. We could go to town
and load configurations from a file, but this is something basic to get the
ball rolling anyway. Works on both py2 & py3, so once we're using this we
also have some confidence the pmda works with either python version.
OK, finally getting back to cleaning up some of my outstanding work for
submission. I think I hit all of your comments. I wasn't quite sure
how to handle the packaging of the .python file in qa so I just copied
the logic from qa/secure and it seems to work. Let me know if you see
any more issues.
https://github.com/ubccr/pcp/tree/micpmda
Convoluted git history below.
Thanks
Martins
commit 13e1815ec3711634c37a5c48050da9f312016304
Author: Martins Innus <minnus@xxxxxxxxxxx>
Date: Thu Aug 13 18:48:49 2015 +0000
pmdamic : Fix QA makefiles
qa/GNUmakefile | 4 ++--
qa/GNUmakefile.install | 2 +-
2 files changed, 3 insertions(+), 3 deletions(-)
commit f939950773d55b5667701320b8d3bed494ca162f
Author: Martins Innus <minnus@xxxxxxxxxxx>
Date: Thu Aug 13 17:51:40 2015 +0000
pmdamic : makefile tab typo
qa/mic/GNUmakefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
commit 17f6cff7d1b8b3cebcec83e73a7940235136b395
Author: Martins Innus <minnus@xxxxxxxxxxx>
Date: Thu Aug 13 17:42:23 2015 +0000
micpmda : fixup some qa python packaging
qa/mic/GNUmakefile | 13 ++++++---
qa/mic/GNUmakefile.install | 20 ++++++++++++++
qa/mic/micmgmt.py | 174
-------------------------------------------------------------------------------------------------------------------
qa/mic/micmgmt.pyc | Bin 8617 -> 0 bytes
qa/mic/micmgmt.pyo | Bin 8617 -> 0 bytes
qa/mic/micmgmt.python | 174
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
6 files changed, 203 insertions(+), 178 deletions(-)
commit 5ce91e2c582b11e330832e05d375b14c38c3552b
Merge: 7f2c18d fec6f94
Author: Martins Innus <minnus@xxxxxxxxxxx>
Date: Mon Jul 6 16:11:00 2015 -0400
Merge branch 'master' into micpmda
Conflicts:
build/rpm/fedora.spec
qa/GNUmakefile
commit 7f2c18d4efc32d2b05ad3d3f022e8c7f14f17c3d
Author: Martins Innus <minnus@xxxxxxxxxxx>
Date: Thu Jun 18 14:19:04 2015 -0400
pmdamic : fix some merge conflict errors
build/rpm/pcp.spec.in | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
commit 8be58eee86bbcd3a0ad971426848a8c108740f8f
Merge: d845a1c 25bba33
Author: Martins Innus <minnus@xxxxxxxxxxx>
Date: Thu Jun 18 12:17:29 2015 -0400
Merge branch 'master' into micpmda
Conflicts:
build/rpm/fedora.spec
build/rpm/pcp.spec.in
commit d845a1cc3cb89e8b0340d44a516bdabcf6472236
Author: Martins Innus <minnus@xxxxxxxxxxx>
Date: Thu Jun 11 19:26:16 2015 +0000
pmdamic : add rpm build logic
build/rpm/fedora.spec | 28 ++++++++++++++++++++++++++--
build/rpm/pcp.spec.in | 30 +++++++++++++++++++++++++++---
2 files changed, 53 insertions(+), 5 deletions(-)
commit ab749845f903ef99097eb929ddeb6ee78c2c89a7
Merge: aff4c26 b493149
Author: Martins Innus <minnus@xxxxxxxxxxx>
Date: Wed Jun 10 15:14:18 2015 -0400
Merge branch 'master' into micpmda
Conflicts:
qa/GNUmakefile
src/pmdas/GNUmakefile
src/pmns/stdpmid.pcp
commit aff4c2608ff5332e90cfd70bd66db03805f2e6ca
Author: Martins Innus <minnus@xxxxxxxxxxx>
Date: Wed Jun 10 18:15:00 2015 +0000
pmdamic : fix idle counters
src/pmdas/mic/pmdamic.python | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
commit feb2e0cbbc7a6b8301bf6c2c479b9275916a904c
Author: minnus@xxxxxxxxxxx <minnus@xxxxxxxxxxx>
Date: Thu Jun 4 19:41:43 2015 +0000
pmdamic : QA and domain fixes
qa/784 | 10 ++++------
qa/784.out | 14 +++++++-------
src/pmdas/mic/pmdamic.python | 2 +-
3 files changed, 12 insertions(+), 14 deletions(-)
commit 67dcc085f9f967d29e6b6ad37764a9d7086c187a
Author: minnus@xxxxxxxxxxx <minnus@xxxxxxxxxxx>
Date: Thu Jun 4 18:51:42 2015 +0000
pmdamic : more bytecompiled files for install
qa/mic/GNUmakefile | 4 ++--
qa/mic/micmgmt.pyc | Bin 7159 -> 8617 bytes
qa/mic/micmgmt.pyo | Bin 0 -> 8617 bytes
3 files changed, 2 insertions(+), 2 deletions(-)
commit aca99fdb960f5d760fe159b0a18436150f57575e
Author: minnus@xxxxxxxxxxx <minnus@xxxxxxxxxxx>
Date: Thu Jun 4 18:36:22 2015 +0000
pmdamic : try to fix build complaining about missing bytecompiled files
qa/mic/micmgmt.pyc | Bin 0 -> 7159 bytes
1 file changed, 0 insertions(+), 0 deletions(-)
commit 1d573a25aa38fbf7a4c1490fad26b9a37676a6e7
Author: Martins Innus <minnus@xxxxxxxxxxx>
Date: Thu Jun 4 13:35:00 2015 -0400
pmdamic : More updates and cleanups
Allow the use of other micmgmt implememations for QA, etc
Change the percore metrics to be seperated by card/core instance
Run as PCP user since we don't require root for any metrics
qa/784 | 8 ++++--
qa/GNUmakefile | 2 +-
qa/mic/GNUmakefile | 16 +++++++++++
qa/mic/micmgmt.py | 174
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/pmdas/mic/Install | 1 -
src/pmdas/mic/micmgmt.py | 174
-----------------------------------------------------------------------------------------------------------------
src/pmdas/mic/pmdamic.ini | 2 --
src/pmdas/mic/pmdamic.python | 157
++++++++++++++++++++++++++++++++++++++++++++----------------------------------------------------------
8 files changed, 263 insertions(+), 271 deletions(-)
commit b2e3e62439397a3fe7613b346920333682d72af6
Author: Martins Innus <minnus@xxxxxxxxxxx>
Date: Wed Jun 3 14:10:12 2015 -0400
pmdamic : fix tabs/spaces issues
src/pmdas/mic/pmdamic.python | 1212
++++++++++++++++++++++++++++++++++++++++++++++++++++++++--------------------------------------------------------
1 file changed, 606 insertions(+), 606 deletions(-)
commit d4b5f03d6b67326b86be70e4d4224d798ea48957
Author: Martins D Innus <minnus@xxxxxxxxxxxxxxxxxxxxxx>
Date: Tue Apr 14 11:13:32 2015 -0400
pmdamic : some cleanups
Fix some copy/paste errors
Start a config file for the micmgmt location
src/pmdas/mic/GNUmakefile | 2 +-
src/pmdas/mic/Install | 4 +--
src/pmdas/mic/Remove | 4 +--
src/pmdas/mic/micmgmt.py | 174
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/pmdas/mic/pmdamic.ini | 2 ++
src/pmdas/mic/pmdamic.python | 15 ++++++----
6 files changed, 191 insertions(+), 10 deletions(-)
commit e2f43db86f34a113c2647addf196b131290fafba
Author: Martins D Innus <minnus@xxxxxxxxxxxxxxxxxxxxxx>
Date: Mon Mar 9 12:05:09 2015 -0400
mic pmda fixes
update qa, fix some naming issues
qa/784 | 12 ++++++++----
qa/784.out | 47
+++++++++++++++++++++++++++++++++++++++++++++++
src/pmdas/mic/GNUmakefile | 2 +-
3 files changed, 56 insertions(+), 5 deletions(-)
commit acb69aa5a9128d71d3d010dec5c167ecfcf56daf
Author: Martins Innus <minnus@xxxxxxxxxxx>
Date: Fri Mar 6 14:45:11 2015 -0500
rename pmdamic.py to pmdamic.python
src/pmdas/mic/pmdamic.py | 651
-----------------------------------------------------------------------------------------------------------------
src/pmdas/mic/pmdamic.python | 651
+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
2 files changed, 651 insertions(+), 651 deletions(-)
commit f479b12470dae666b23a53fff17a8d51f4ba6d7f
Author: Martins Innus <minnus@xxxxxxxxxxx>
Date: Fri Mar 6 13:55:17 2015 -0500
mic pmda initial commit
Uses the mpss libmicmgmt python bindings to collect stats on
the mic card.
Runs on the host, not the mic card.
qa/784 | 64 ++++++++++++
qa/group | 1 +
src/pmdas/GNUmakefile | 2 +-
src/pmdas/mic/GNUmakefile | 40 ++++++++
src/pmdas/mic/Install | 28 +++++
src/pmdas/mic/Remove | 25 +++++
src/pmdas/mic/pmdamic.1 | 59 +++++++++++
src/pmdas/mic/pmdamic.py | 651
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
src/pmns/stdpmid.pcp | 1 +
9 files changed, 870 insertions(+), 1 deletion(-)
|