Ken McDonell <kenj@xxxxxxxxxxxxxxxx> writes:
>> The part about *pmGetInDomArchive* is kind of bothering me, since it
>> looks like it's spending most of its time in that method.
>>
>> Any thoughts on how to improve my experience ?
>
> Can you send me one of the archives?
Me too me too! :-)
We haven't encountered this particular hanging fruit before.
> A quick look at the pmwebd source suggests that it is processing the
> metadata in the pmns traversal callback ... if there are lots of
> metrics over the _same_ instance domain, and that instance domain is
> large, then this will call pmGetInDomArchive O(# metrics with the same
> indom) instead of O(1).
>
> If my crude analysis is correct (this is not my code), then this looks
> to be a candidate for some serious code optimization.
> [...]
Thanks! More caching (whether within pmwebd or libpcp) would likely
help this case. Will ponder it deeper once we have the problem child ^W
archive in hand.
- FChE
|