pcp
[Top] [All Lists]

Re: [pcp] pcp updates: pmcpp

To: Lukas Berk <lberk@xxxxxxxxxx>
Subject: Re: [pcp] pcp updates: pmcpp
From: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue, 28 Jul 2015 06:11:33 +1000
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <87egjtzk12.fsf@xxxxxxxxxx>
References: <55B2DEE0.8080809@xxxxxxxxxxxxxxxx> <87egjtzk12.fsf@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
G'day Lukas.

On 28/07/15 01:40, Lukas Berk wrote:

...
I believe this broke compilation for me on my fedora 22 box (gcc appears
to use gnu11 by default for C code).  Specifically the use of 'restrict'
keyword is causing problems.

Ouch! Haven't seen that at all on the Debian-based platforms I develop on, and it has not made its way far enough through my QA farm to have been reproduced yet.

Would the attached patch work for you? (I'll post it with a few other
pmcollectl patches I have locally later today in a pcp updates email if
so).

I think for consistency I'd rather use rflag than _restrict for the name of the variable. I broke it, so I'll fix it. Commit on its way shortly.

Sorry for the disruption and thanks for the heads up.

<Prev in Thread] Current Thread [Next in Thread>