Hi Lukas,
----- Original Message -----
> [...]
> Marc, could you perhaps elaborate a little bit more on the memory leak
> you were seeing? How did you identify it? Was there a testcase
> submitted with the patch at all? (Mark, maybe you have a pointer to
> this? I haven't see any in the tree or git logs).
There isn't one - I looked into making a valgrind-based test, but there's
overwhelming memcheck noise coming out of python itself that made me back
slowly away. Probably we should go back to that at some point, but since
its in pmsubsys.py which is pretty much deprecated now, I figured it was
OK & seemed an "obvious" fix. Guess not.
> I'd be happy to create an archived based testcase for this moving
> forward (once we have the fix), to verify the values we're seeing out of
> pmcollectl make sense. However, until the time being would it make
> senes to revert this patch until we have a fix?
Yep, please send a revert through while its considered some more. If we
find someone to convert pmcollectl over to pcp.pmcc then we could start
deprecating pmsubsys a bit more formally.
cheers.
--
Nathan
|