pcp
[Top] [All Lists]

Re: Solaris build notes

To: "Josef 'Jeff' Sipek" <jeffpc@xxxxxxxxxxxxxx>
Subject: Re: Solaris build notes
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Sun, 28 Jun 2015 18:43:55 -0400 (EDT)
Cc: pcp <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <20150628144122.GB101529@xxxxxxxxxxxxxxxxxxxxxxxxx>
References: <474160992.25596336.1435198655884.JavaMail.zimbra@xxxxxxxxxx> <1945955780.25644422.1435200191659.JavaMail.zimbra@xxxxxxxxxx> <20150628144122.GB101529@xxxxxxxxxxxxxxxxxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: /S+92vyGz4R3GjMKwgM7aTOUbLLO6w==
Thread-topic: Solaris build notes

----- Original Message -----
> FWIW, the following commit broke compilation of pcp on illumos-derived
> distros.
> (I bet FreeBSD and ZFSonLinux are affected too since they collaborate with
> the illumos ZFS folks.)  It'd seem that Oracle added an arg to
> zpool_vdev_name() which obviously isn't available in the open source
> versions of ZFS.  Oh, the joys of diverging code.

Oh darn.  Looking at the git log, this is the second extra argument that
has been added to this API now.  I'll add some autoconf checking to deal
with each variant, thats probably the best we can do.  :(

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>