Changes committed to git://git.pcp.io/kenj/pcp master
Ken McDonell (7):
qa/json: really install GNUmakefile.install now
build/rpm/pcp.spec.in: guard manifest processing when rpm pmda not being
built
qa: build and infrastructure (symlink help)
qa/pmdas: assorted - don't remake the binaries from GNUmakefile.install
src/libpcp/interp.c: catch bad valfmt encoding changes
qa/931: re-enable in group and add .out file
pmlogcheck: teach it about valfmt badness
build/rpm/pcp.spec.in | 6 +-
debian/pcp-testsuite.postinst | 2
man/man1/pmlogcheck.1 | 18 +++++-
qa/931 | 2
qa/931.out | 104 +++++++++++++++++++++++++++++++++++
qa/common | 2
qa/group | 2
qa/json/GNUmakefile | 1
qa/pmdas/bigun/GNUmakefile.install | 2
qa/pmdas/broken/GNUmakefile.install | 2
qa/pmdas/dynamic/GNUmakefile.install | 4 -
src/libpcp/src/interp.c | 67 ++++++++++++++++++----
src/pmlogcheck/pass3.c | 22 +++++++
13 files changed, 209 insertions(+), 25 deletions(-)
Details ...
commit a2147189bde49eb1dcfac0ec51d8a79f703db1f6
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Jun 23 16:43:02 2015 +1000
pmlogcheck: teach it about valfmt badness
Based on the fix for http://oss.sgi.com/bugzilla/show_bug.cgi?id=1100
in libpcp, extend pmlogcheck to detect and report this style of
archive corruption.
Update the man page accordingly.
commit 57db33a62e408df2cb77bcde732de71be5adc520
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Jun 23 16:41:55 2015 +1000
qa/931: re-enable in group and add .out file
With the fix in libpcp, this test is now open for business.
commit e2b77c8bbbea39c108b106a9664929cbd8ec2921
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue Jun 23 16:32:43 2015 +1000
src/libpcp/interp.c: catch bad valfmt encoding changes
Bug http://oss.sgi.com/bugzilla/show_bug.cgi?id=1100 was caused
by a bad archive in which the valfmt field for some specific metrics
was not constant across all pmResults. This should never happen in
production environments, but appears possible in developer environments
where the metadata for a PMDA could change during development, leaving
some concatenated archive with both before and after encoding schemes.
This commit traps the condition in libpcp and returns PM_ERR_LOGREC
(Corrupted record in a PCP archive log) rather than wandering off into
the swamp of undefined pointer dereferencing, pdubuf integrity check
failures and free/malloc badness.
commit 68f2dcbf443f66ead81ced6f2b248fd62f9f2df9
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Jun 22 11:50:47 2015 +1000
qa/pmdas: assorted - don't remake the binaries from GNUmakefile.install
For these QA pmdas, the binaries are built in the build and
installed below $PCP_VAR_DIR/testsuite ... the GNUmakefiles that
are installed there should not (by default) remake the binaries.
commit 1fc0140537ccb1ee56e41b1f228ef4d099293e0f
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Jun 22 11:36:21 2015 +1000
qa: build and infrastructure (symlink help)
If $PCP_VAR_DIR/testsuite is a symlink (as it is on one of my
machines to get it out of /var so I can create the jinormous but
optional archive for src/big1) then debian postinst script and
a test in qa/common failed.
commit 202cff67062d8b4a8297768db8951e3d9e835749
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Jun 22 11:33:06 2015 +1000
build/rpm/pcp.spec.in: guard manifest processing when rpm pmda not being
built
Treat the same way as the other optional pmdas with a
%if "@pmda_rpm@" == "true"
guard before the manifest processing.
Also make the use of @pmda_foo@ guards consistent in a couple
of places (purely cosmetic change).
commit 962f0f69659ea92b42bcd7b43097c083485a58f1
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Jun 22 11:30:41 2015 +1000
qa/json: really install GNUmakefile.install now
|