pcp
[Top] [All Lists]

Re: [pcp] pcp updates: ipc.shm metrics on linux

To: Lukas Berk <lberk@xxxxxxxxxx>
Subject: Re: [pcp] pcp updates: ipc.shm metrics on linux
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Mon, 22 Jun 2015 02:28:29 -0400 (EDT)
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <87616kln9j.fsf@xxxxxxxxxx>
References: <87616kln9j.fsf@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: sR6K3ZB29y+K2R+eKGTc9YZJaq2+PA==
Thread-topic: pcp updates: ipc.shm metrics on linux
Hi Lukas,

----- Original Message -----
> Hi,
> 
> Changes committed to ssh://git.pcp.io/oss/git/lberk/pcp.git master

(for folks without accounts, "git://git.pcp.io/lberk/pcp.git master")

> These two commits add pmdalinux support for ipc.shm.{tot,rss,swp}
> metrics, as well as qa.  It passes a ./check -g pmda.linux test for me.
> 
> It's my first time writing a mini library and using LD_PRELOAD to return
> set values, so a critical eye to my approach would be greatly
> appreciated.

Good stuff - difficult to find any fault at all.  I made one teensy
tweak to the QA test, to use the $here variable and to fail the test
if the test source cannot be found (rather than notrun) - please can
you double-check that for me?  Thanks1!

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>