pcp fedora.spec review comments and patch

[Mark Goodwin <mgoodwin@xxxxxxxxxx>]

[was supposed to be writing the CHANGELOG tonight, but did this instead]

I built f22 packages using rpmbuild -ba ~/rpmbuild/SPECS/pcp.spec
using build/rpm/fedora.spec as ~/rpmbuild/SPECS/pcp.spec
and the src tarball from a Makepkgs build as
~/rpmbuild/SOURCES/pcp-3.10.5.src.tar.gz

This is basically a local equivalent of a fedpkg build. Probably should
have done a fedpkg build, but my fedora certs are out of date (will fix
that tomorrow).

This needed some fixes in the fedora.spec (see attached patch), before
it would build correctly. Lukas has done a fine job getting the
fedora spec into shape - it's pretty complex and just needs a few tweaks
to finish it off.

With the attached patch applied to the fedora spec, I ran two builds;
one using Makepkgs and the other using rpmbuild with the patched fedora
spec - with the intent to compare the resulting RPMs. These two builds
were done on the same f22 system, i.e. with exactly the same build
environment and build dependencies installed.

So to compare the resulting RPM packages I wrote a script to extract the
set of filenames in each of the RPMs from both builds, sort the lists
and prefix each line with the RPM package name containing it.
(see attached makepkgs.all and fedora.all to see what I mean). The fedora
package filenames have .fc22 removed - see the script- so that the
RPM filenames are the same for diff purposes.

Then compared the resulting lists with a graphical diff (I used xxdiff).
The script and two lists are attached: see compare-pcp-packaging.sh,
makepkgs.all and fedora.all. There are quite a lot of differences and
issues we need to work thru - I'll finish this off tomorrow but hopefully
Lukas or someone can take it on over night and make some progress.

attachments: pcp-fedora.spec.patch compare-pcp-packaging.sh fedora.all 
makepkgs.all

To see the packaging differences: xxdiff makepkgs.all fedora.all

Cheers
-- Mark

pcp-fedora.spec.patch
Description: Text Data

compare-pcp-packaging.sh
Description: application/shellscript

makepkgs.all
Description: Text document

fedora.all
Description: Text document