On 06/04/2015 07:47 PM, Nathan Scott wrote:
> Hi David,
>
> ----- Original Message -----
>> [...]
>> When you say things are "non-deterministic" do you mean that sometimes
>> you see a pass? I certainly never saw this kind of behavior when I was
>> testing.
>
> I always see it fail the same way on the 2 hosts I've run it so far. I say
> "non-deterministic" because its produced different output for you when you
> initially saved the golden output for the test.
>
> I imagine its to do with different hashing schemes across the different
> versions of python, and not a real problem in the new code.
>
>> Hmm. Since we have fairly full control over commands here, we could do
>> something like the following (untested) patch. Basically we sort the
>> output of only the 'children json' dbpmda command
>>
>
> *nod* - this is what Ken's suggesting too.
>
>>
>> Note there are a couple of other places that would need the same treatment.
>>
>
> Yeah, I think we'll need to go ahead & do this kind of thing.
On the pcpfans.git dsmith/dev branch, I've done this in the following
commit:
====
commit fc785142078eec77fe40926fb4fa6efd6c1e4ef3
Author: David Smith <dsmith@xxxxxxxxxx>
Date: Tue Jun 9 12:36:06 2015 -0500
Make the JSON PMDA qa test more robust.
* qa/1052: Sort output of certain commands, to avoid problems with
differing python internal ordering.
* qa/1052.out: Updated.
====
--
David Smith
dsmith@xxxxxxxxxx
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)
|