pcp
[Top] [All Lists]

pcp updates - for review - deprecate hinv.nlv and hinv.map.lvname

To: pcp <pcp@xxxxxxxxxxx>
Subject: pcp updates - for review - deprecate hinv.nlv and hinv.map.lvname
From: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Fri, 05 Jun 2015 14:47:21 +1000
Delivered-to: pcp@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.3.0
For RHBZ#1109539 - hinv.map.lvname instance IDs are not persistent

Requesting review before I merge this one, thanks in advance. If these
changes are OK, then I'll also need to tweak qa/{003,232,540}.

Changes committed to git://git.pcp.io/markgw/pcp/pcp.git derecate-lvmname
(note the branch name!).

commit ab4eb4adbfec797f51becf3298f5b78f350dcaed
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date:   Fri Jun 5 14:23:37 2015 +1000

    Deprecate hinv.nlv and hinv.map.lvname and the LV_NAME instance domain.

    The instance domain for hinv.map.lvname is the dm names e.g. dm-1,
    which are not persistent. The values are the logical names, which
    are persistent. These two metrics are now deprecated in favor of
    hinv.map.dmname, which instead uses the persistent names for the
    instance domain, and the dm names as the value of the mapping.

    Note also - hinv.map.dmname is a superset of the lvm instances -
    the dmname instance domain also includes non-lvm devices such as
    dm-multipath, dm-cache, etc.  as well as all lvm logical devices.

    The only known user of the deprecated hinv.map.lvname metric is the
    old pmatop command, which itself has been deprecated.

        modified:   src/pmdas/linux/GNUmakefile
        modified:   src/pmdas/linux/clusters.h
        deleted:    src/pmdas/linux/devmapper.c
        deleted:    src/pmdas/linux/devmapper.h
        modified:   src/pmdas/linux/help
        modified:   src/pmdas/linux/indom.h
        modified:   src/pmdas/linux/pmda.c
        modified:   src/pmdas/linux/root_linux

<Prev in Thread] Current Thread [Next in Thread>