Nathan, we should consider pushing the atop buffer overflow
fixes back upstream - they're mostly in unmodified code right?
Changes committed to git://git.pcp.io/pcp.git master
Ken McDonell (14):
qa: assorted tests, ensure $seq.full is truncated first
qa/qt: add setup target for GNUmakefiles
qa/cisco: add installed GNUmakefile
qa/gluster: add installed GNUmakefile
qa/pconf: add installed GNUmakefile
qa/sadist: add installed GNUmakefile
qa/collectl: add installed GNUmakefile
qa/qt: don't decend into the subdirs for setup with the installed
GNUmakefile
qa/unbound: add installed GNUmakefile
qa/gpfs: add installed GNUmakefile
src/include/builddefs.in: promote QA SUBDIRS rule to a common place
qa/admin/whatami: add heuristic for RHEL systems
qa/admin/check-vm: add logconv.pl needed by the ds389log pmda
qa: lots of makefiles
Nathan Scott (5):
pmie: prevent premature rule evaluation in pmie live mode
pcp-atop: complete audit of string buffers for overflows
build: add struct declarations for remaining few headers
man pages: update atop man page, small tweaks for others
pcp-atop: implement record mode functionality (-w option)
qa/038 | 2
qa/1045 | 1
qa/1079 | 7
qa/1079.out | 3
qa/115 | 1
qa/145 | 3
qa/223 | 1
qa/638 | 1
qa/647 | 1
qa/704 | 1
qa/722 | 113 ---
qa/722.out | 904 -------------------------
qa/862 | 41 +
qa/862.out | 2
qa/GNUmakefile.install | 23
qa/admin/check-vm | 1
qa/admin/whatami | 17
qa/cisco/GNUmakefile | 1
qa/cisco/GNUmakefile.install | 51 +
qa/collectl/GNUmakefile | 3
qa/collectl/GNUmakefile.install | 48 -
qa/ganglia/GNUmakefile | 3
qa/ganglia/GNUmakefile.install | 20
qa/ganglia/gangliatest.32/GNUmakefile | 3
qa/ganglia/gangliatest.32/GNUmakefile.install | 18
qa/ganglia/gangliatest.64/GNUmakefile | 3
qa/ganglia/gangliatest.64/GNUmakefile.install | 18
qa/ganglia/gangliatest.xml/GNUmakefile | 3
qa/ganglia/gangliatest.xml/GNUmakefile.install | 18
qa/gluster/GNUmakefile | 3
qa/gluster/GNUmakefile.install | 52 +
qa/gpfs/GNUmakefile | 3
qa/gpfs/GNUmakefile.install | 47 -
qa/group | 2
qa/lustre/GNUmakefile | 3
qa/lustre/GNUmakefile.install | 19
qa/nfsclient/GNUmakefile | 3
qa/nfsclient/GNUmakefile.install | 21
qa/pconf/GNUmakefile | 1
qa/pconf/GNUmakefile.install | 53 +
qa/pmdas/GNUmakefile.install | 21
qa/qt/GNUmakefile.install | 26
qa/qt/qmc_context/GNUmakefile | 2
qa/qt/qmc_desc/GNUmakefile | 2
qa/qt/qmc_dynamic/GNUmakefile | 2
qa/qt/qmc_event/GNUmakefile | 2
qa/qt/qmc_format/GNUmakefile | 2
qa/qt/qmc_group/GNUmakefile | 2
qa/qt/qmc_hosts/GNUmakefile | 2
qa/qt/qmc_indom/GNUmakefile | 2
qa/qt/qmc_metric/GNUmakefile | 2
qa/qt/qmc_source/GNUmakefile | 2
qa/sadist/GNUmakefile | 1
qa/sadist/GNUmakefile.install | 50 +
qa/unbound/GNUmakefile | 3
qa/unbound/GNUmakefile.install | 50 +
src/include/builddefs.in | 13
src/include/pcp/mmv_dev.h | 16
src/include/pcp/pmafm.h | 2
src/include/pcp/pmtime.h | 10
src/pcp/atop/GNUmakefile | 2
src/pcp/atop/atop.c | 58 -
src/pcp/atop/atop.h | 25
src/pcp/atop/atopsar.c | 39 -
src/pcp/atop/hostmetrics.map | 6
src/pcp/atop/ifpropmetrics.map | 2
src/pcp/atop/parseable.c | 4
src/pcp/atop/pcp-atop.1 | 109 +--
src/pcp/atop/pcp-atopsar.1 | 40 -
src/pcp/atop/photoproc.h | 7
src/pcp/atop/photosyst.h | 16
src/pcp/atop/procmetrics.map | 2
src/pcp/atop/showgeneric.c | 20
src/pcp/atop/showgeneric.h | 6
src/pcp/atop/showlinux.c | 21
src/pcp/atop/showlinux.h | 17
src/pcp/atop/showprocs.c | 185 ++---
src/pcp/atop/showsys.c | 139 +--
src/pcp/atop/systmetrics.map | 7
src/pcp/atop/various.c | 206 ++++-
src/pcp/dmcache/pcp-dmcache.1 | 2
src/pcp/free/pcp-free.1 | 2
src/pcp/numastat/pcp-numastat.1 | 2
src/pcp/uptime/pcp-uptime.1 | 2
src/pcp/verify/pcp-verify.1 | 2
src/pmie/src/pmie.c | 6
86 files changed, 1040 insertions(+), 1617 deletions(-)
Details ...
commit 69a4070b7ad5fa9d8816c8f77ef74c45e75ba83c
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Thu Jun 4 16:40:47 2015 +1000
pcp-atop: implement record mode functionality (-w option)
Creating archive folios now works as per our earlier atop.
Test qa/1079 is updated to create and the replay an archive
using this facility and the old python atop test is retired.
commit a78e0f6bc65c532eb666309af09ed0cd358449a4
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Thu Jun 4 16:30:33 2015 +1000
man pages: update atop man page, small tweaks for others
commit 2fa8d8c6bfab218bbe46ed5def0137824379a2a6
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Thu Jun 4 15:57:56 2015 +1000
build: add struct declarations for remaining few headers
commit 64ae58d19067544ff424ab2170e5678a1cb2370d
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Thu Jun 4 12:58:45 2015 +1000
pcp-atop: complete audit of string buffers for overflows
commit 1631ea89c76f8a24c664b84ebcf875ca35ab263c
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed Jun 3 14:42:04 2015 +1000
pmie: prevent premature rule evaluation in pmie live mode
Resolve an issue introduced in commit d21bb6c017696 - some
code Ken and I thought was unnecessary turned out to be in
use after all. The rest of that commit remains, it's just
the snippet of code that re-adjusts the Task scheduling vs
the current time that is affected by slow reading on stdin
(which can happen if rules are manually entered).
Added a new qa/862 test to exercise the situation and fix.
commit 689d6d1000758031197a0cdd9bfde19cc1feab1c
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jun 3 16:59:44 2015 +1000
qa: lots of makefiles
Complete the coverage of installed GNUmakefiles across all the
QA directories.
Also use the $(QA_SUBDIRS_MAKERULE) macro in preference to
$(SUBDIRS_MAKERULE) in the installed GNUmakefiles.
commit 12e319e69bd2e426d6851ccfeb0373c66c21948d
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jun 3 16:59:03 2015 +1000
qa/admin/check-vm: add logconv.pl needed by the ds389log pmda
commit 749b21d75a8d04b8bb180e94cc77b8345c3b3bae
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jun 3 16:56:11 2015 +1000
qa/admin/whatami: add heuristic for RHEL systems
commit 9a1f660e2cea4dde6325af7768c091fe337c7c63
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jun 3 16:43:49 2015 +1000
src/include/builddefs.in: promote QA SUBDIRS rule to a common place
In the GNUmakefile.install files below the qa directory we want to
run make in a more terse mode to reduce the clutter on stdout.
This commit adds QA_SUBDIRS_MAKERULE that is very similar to
SUBDIRS_MAKERULE except for
(a) preferring to use GNUmakefile.install if present rather
than GNUmakefile, and
(b) no chatter as you descend through directories
commit 59f86189b35e237b5cfaac7492d5e02226283a93
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jun 3 10:32:25 2015 +1000
qa/gpfs: add installed GNUmakefile
commit 28787141b7f80e742fcdd8d10f0100a020273470
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jun 3 10:30:02 2015 +1000
qa/unbound: add installed GNUmakefile
commit 2e4c8284a98626b18de3f0d27aea1fe48be8d70f
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jun 3 10:27:06 2015 +1000
qa/qt: don't decend into the subdirs for setup with the installed
GNUmakefile
The qmc_* binaries cannot be rebuilt from $PCP_VAR_DIR/testsuite, so
don't even try.
commit e123508f9146291b672f23850720b9bd3288f3b5
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jun 3 10:20:58 2015 +1000
qa/collectl: add installed GNUmakefile
commit f20f5e072883aa047ad378bb2c36716250ef9715
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jun 3 10:18:02 2015 +1000
qa/sadist: add installed GNUmakefile
commit 7f20617d691c94795a0d4ce212d73059f9ea5307
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jun 3 10:15:40 2015 +1000
qa/pconf: add installed GNUmakefile
commit 7c7abe8bddb47a7359dd87e1d6d252450eb6082a
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jun 3 10:11:06 2015 +1000
qa/gluster: add installed GNUmakefile
commit 76021fa53d27763e8f1c29a522bfd338c62adf79
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jun 3 10:08:02 2015 +1000
qa/cisco: add installed GNUmakefile
commit 57937a474693794a458a101269bf40c59936881c
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed Jun 3 09:24:05 2015 +1000
qa/qt: add setup target for GNUmakefiles
make setup was failing ... we don't use this often (like never until
I was testing some unrelated gmake changes), but fix it to be complete.
ps. the more usual make -f GNUmakefile.install setup works because it
does not descend into the qt directory, which is another but different
issue for another commit.
commit f73463b72a9a64984e88b694357b6ea7d76874e3
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Mon Jun 1 07:10:29 2015 +1000
qa: assorted tests, ensure $seq.full is truncated first
These tests were appending to $seq.full without ensuring it
was initially truncated.
|