Anyone know who the "EC2 Default User" user is? They submitted a
valgrind inspired memleak fix - the authorship might need fixing up.
Changes committed to git://git.pcp.io/pcp.git master
Ken McDonell (15):
qa/src/pducrash.c: plug small mem leak
pmlogextract: one additional corner case for -d
jbd2 pmda: add pmlogrewrite support for KERNEL_ULONG metrics
jbd2 pmda: add jbd2_kernel_ulong.conf to .gitignore
linux pmda: fix up types for some disk i/o metrics
linux pmda: add pmlogrewrite support for KERNEL_ULONG metrics
linux pmda: add pmlogrewrite clause for disk.dm.total
linux_proc pmda: small help text change
linux_proc pmda: cleanup up the jiffies -> msec calculations
linux_proc pmda: add pmlogrewrite support for KERNEL_ULONG and
jiffy-based metrics
linux_proc pmda: add missing file mk.rewrite
debian: packaging issue ... missing pmGetOptionalConfig.3.gz entry
linux pmda: restore pmlogrewrite config file name
qa/769: remove 769.out ... not needed
pmdaproc.sh: temp file handling
Lukas Berk (7):
spin-rawhide: Extract version info from VERSION.pcp
Fix location of pcp-webjs gitweb in the pcp guide
Wrap pcp-pmda-rpm and pcp-gui with proper %if checks
Update qa/566 with -z options and update output
Add regex to qa/956 for failures when extra '.'s are seen in the output
Mirror pcp.spec.in package breakup into fedora.spec
Revert Source0 location to upstream
Nathan Scott (7):
pmdalinux: code refactoring, common source files for ipc metrics
build: add ncurses configure checking via pkg-config for console tools
build: add struct declarations for application headers
pmdalinux: add /proc/meminfo hugepagesize metric, used by atop
pmdaproc: add two /proc/pid/status metrics, used by atop
qa: fix systemd pmda Install spurious .err output
qa: add gitignore file for perl test dirt
EC2 Default User (1):
libpcp_pmda: Fixed a memory leak detected by valgrind.
Martins Innus (1):
Fixup some of the time types in linux_proc
build/rpm/fedora.spec | 1331 ++++++++++++++++++++++++++++++++----
build/rpm/pcp.spec.in | 17
configure | 83 ++
configure.ac | 3
debian/libpcp3-dev.install | 1
man/html/guide.html | 2
man/man3/pmda.3 | 111 +--
qa/022.out.linux | 2
qa/566 | 33
qa/566.out | 16
qa/652 | 37 -
qa/652.out | 3
qa/769.out | 17
qa/943.out | 2
qa/956 | 6
qa/974.out | 236 ------
qa/perl/.gitignore | 2
qa/src/pducrash.c | 1
scripts/spin-rawhide | 12
src/include/builddefs.in | 5
src/include/pcp/pmapi.h | 41 -
src/include/pcp/pmda.h | 19
src/libpcp_pmda/src/mainloop.c | 2
src/pmcd/pmdaproc.sh | 12
src/pmdas/cisco/Install | 4
src/pmdas/jbd2/.gitignore | 1
src/pmdas/jbd2/GNUmakefile | 11
src/pmdas/jbd2/mk.rewrite | 36
src/pmdas/linux/.gitignore | 1
src/pmdas/linux/GNUmakefile | 32
src/pmdas/linux/convert.h | 2
src/pmdas/linux/help | 4
src/pmdas/linux/ipc.c | 80 ++
src/pmdas/linux/ipc.h | 65 +
src/pmdas/linux/mk.rewrite | 63 +
src/pmdas/linux/msg_limits.c | 49 -
src/pmdas/linux/msg_limits.h | 35
src/pmdas/linux/pmda.c | 46 -
src/pmdas/linux/proc_meminfo.c | 3
src/pmdas/linux/proc_meminfo.h | 3
src/pmdas/linux/proc_partitions.c | 24
src/pmdas/linux/root_linux | 3
src/pmdas/linux/sem_limits.c | 51 -
src/pmdas/linux/sem_limits.h | 49 -
src/pmdas/linux/shm_limits.c | 43 -
src/pmdas/linux/shm_limits.h | 32
src/pmdas/linux_proc/.gitignore | 4
src/pmdas/linux_proc/GNUmakefile | 10
src/pmdas/linux_proc/help_text.h | 6
src/pmdas/linux_proc/mk.rewrite | 52 +
src/pmdas/linux_proc/pmda.c | 269 ++++---
src/pmdas/linux_proc/proc_dynamic.c | 6
src/pmdas/linux_proc/proc_pid.c | 8
src/pmdas/linux_proc/proc_pid.h | 4
src/pmdas/sample/Install | 4
src/pmdas/shping/Install | 8
src/pmdas/systemd/.gitignore | 1
src/pmdas/systemd/Install | 5
src/pmdas/weblog/Install | 46 -
src/pmlogextract/pmlogextract.c | 9
60 files changed, 2082 insertions(+), 981 deletions(-)
Details ...
commit 6e20f93528d0efd6ff59c39a4d18ac6847664667
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Mon May 25 12:38:32 2015 +1000
qa: add gitignore file for perl test dirt
commit 282fa906b234e5ea50a639faf2c0bfabecff3a75
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Mon May 25 12:38:02 2015 +1000
qa: fix systemd pmda Install spurious .err output
Turned out to be a $tmp assumption, but nothing was being
done with the journalctl stderr stashed in $tmp.err anyway
so just send it to /dev/null like stdout (the return code
is all that matters here).
While there, remove some unnecessary code & tweak a couple
the delays in qa/652 to make it complete more quickly.
commit af0fefdf9b8d983da2d9f26c8439a9b39b60c393
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Fri May 22 16:59:21 2015 +1000
pmdaproc: add two /proc/pid/status metrics, used by atop
commit 74cdac00b2cdd0c9bc0b94d401c9bf7cfa115c8f
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sat May 23 11:24:29 2015 +1000
pmdaproc.sh: temp file handling
My last round of changes to pmdaproc.sh sort of left this in a
bit of a mess.
Clean it up, fix all the PMDA Install scripts and document in the
man page how it is supposed to work.
commit bcc121c5545fb0edca231ec128dd405c5ede37fa
Author: Lukas Berk <lberk@xxxxxxxxxx>
Date: Fri May 22 18:18:29 2015 -0400
Revert Source0 location to upstream
commit 5eb8a53a6afdfa9650c0bb5581f813621c9b4733
Author: Lukas Berk <lberk@xxxxxxxxxx>
Date: Fri May 22 18:16:44 2015 -0400
Mirror pcp.spec.in package breakup into fedora.spec
commit 3e6d504704b0133dcc378b3d594665bbdd5d53f9
Author: Lukas Berk <lberk@xxxxxxxxxx>
Date: Fri May 22 12:56:37 2015 -0400
Add regex to qa/956 for failures when extra '.'s are seen in the output
commit fd9dfebe78b464fd7e254c1e63b9fd7352772998
Author: Lukas Berk <lberk@xxxxxxxxxx>
Date: Fri May 22 12:19:51 2015 -0400
Update qa/566 with -z options and update output
566 was failing due to timezone differences, updating the commands
with the -z parameter also produced additional output related to
the timezone option. Filter out the names of the hosts.
commit 931b78c721efbed24adf05a73d53d65268b2cf57
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri May 22 19:58:15 2015 +1000
qa/769: remove 769.out ... not needed
commit 5563e6df24e9d42434e6688b1f9b0a03d7dda870
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri May 22 18:10:00 2015 +1000
linux pmda: restore pmlogrewrite config file name
Last round of commits accidentally renamed linux_proc_net_snmp_migrate.conf
to proc_net_snmp_migrate.conf ... reverse that.
commit f270bc0d32fb22a9cc15816c913fc0e0b6c46e6f
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Fri May 22 16:58:43 2015 +1000
pmdalinux: add /proc/meminfo hugepagesize metric, used by atop
commit 2a32ca8b4f055776597c23f54931d0da25b2eecb
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Fri May 22 16:51:21 2015 +1000
build: add struct declarations for application headers
Add struct names for all structures, as is done in a couple of places
in pmapi.h and throughout impl.h. This is useful to applications that
don't want to include pmapi.h and instead forward-declare structs that
they use. The atop upstream code has headers using this model, which
we'll want to integrate with shortly.
commit 88ac884d58cdb5651efa01af26e084ef42b0a087
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Fri May 22 16:31:42 2015 +1000
build: add ncurses configure checking via pkg-config for console tools
commit 04fe8ac311d6c3c224288abd65a01e3a03b1493d
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri May 22 11:43:06 2015 +1000
debian: packaging issue ... missing pmGetOptionalConfig.3.gz entry
Missing from the manifest for libpcp3-dev.
commit 4686004759188c1ec192fe7a870588d86d2d0796
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri May 22 09:43:55 2015 +1000
linux_proc pmda: add missing file mk.rewrite
Should have been part of previous commit.
commit 59bdfd460902c2b5924114b19041ab779cb6efd3
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri May 22 09:41:35 2015 +1000
linux_proc pmda: add pmlogrewrite support for KERNEL_ULONG and jiffy-based
metrics
Because the PCP type of the KERNEL_ULONG metrics is not constant
across platforms, it helps to provide pmlogrewrite rules to ensure
the type is correct, e.g. for archives that may have come from
an older platform environment (32-bit) when processed in a newer
platform environment (64-bit).
Also capture some recent metadata changes in the jiffy-based metrics.
commit 9bf8718bbbd8849127edd6886d9d1819bdb8c45b
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri May 22 09:41:07 2015 +1000
linux_proc pmda: cleanup up the jiffies -> msec calculations
commit 5bd2216b329035551eb82978ec480410b4dba6a7
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu May 21 15:35:55 2015 +1000
linux_proc pmda: small help text change
Change "in miliseconds" (sic) to "(in ms)" to match other
entries.
commit 4b6e2689235c3202b15b24493c3e6ea7df73194a
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu May 21 15:32:13 2015 +1000
linux pmda: add pmlogrewrite clause for disk.dm.total
Should be PM_TYPE_U64 on all platforms.
commit 5ee887dcc24f7c6f3a4ffaae58f5ffffdf0f7238
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu May 21 15:28:35 2015 +1000
linux pmda: add pmlogrewrite support for KERNEL_ULONG metrics
Because the PCP type of these metrics is not constant across
platforms, it helps to provide pmlogrewrite rules to ensure
the type is correct, e.g. for archives that may have come from
an older platform environment (32-bit) when processed in a
newer platform environment (64-bit).
commit 656cec37a42d05f337b893bd992e77177f4ac14d
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu May 21 15:16:51 2015 +1000
linux pmda: fix up types for some disk i/o metrics
Several metrics shold have been of the platform-specific type
KERNEL_ULONG.
+ disk.dev.blkread and disk.dev.blkwrite were PM_TYPE_U64
+ disk.partitions.read, disk.partitions.write,
disk.partitions.blkread and disk.partitions.blkwrite were
PM_TYPE_U32
+ disk.dm.blkread and disk.dm.blkwrite were PM_TYPE_U64
And disk.dm.total was KERNEL_ULONG but should have been
PM_TYPE_U64.
pmlogrewrite support for these changes is in the next commit.
commit 48cd9beda20b026e17abc4bd2ce4d723fc9c9d47
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu May 21 15:14:44 2015 +1000
jbd2 pmda: add jbd2_kernel_ulong.conf to .gitignore
commit a6935736d144d68bb4710bd36e75e63b963a0adb
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu May 21 11:33:36 2015 +1000
jbd2 pmda: add pmlogrewrite support for KERNEL_ULONG metrics
Because the PCP type of these metrics is not constant across
platforms, it helps to provide pmlogrewrite rules to ensure
the type is correct, e.g. for archives that may have come from
an older platform environment (32-bit) when processed in a
newer platform environment (64-bit).
commit 624f532b7e7311f2601aba364ec6830a3cdea576
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Thu May 21 06:35:19 2015 +1000
pmlogextract: one additional corner case for -d
If one of the input archives is truncated, then pmGetArchiveEnd()
may fail ... this is not fatal (when -d is specified) so processing
should continue.
commit f7d34129d7534761bcd193f09a276888d0a1f2e1
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed May 20 15:59:54 2015 +1000
pmdalinux: code refactoring, common source files for ipc metrics
commit f3651868be5c9495382270016d4cd604a6a6bca0
Author: Martins Innus <minnus@xxxxxxxxxxx>
Date: Thu May 14 19:39:32 2015 +0000
Fixup some of the time types in linux_proc
Some metrics were reporting as seconds when they were not. Fix
them to be msec as appropriate.
Some metrics with type KERNEL_ULONG had some explcit uint32
conversions. Try to generalize.
commit 22e71855d99b448226d40e793c9eb43e36d963d6
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Sun May 17 17:04:59 2015 +1000
qa/src/pducrash.c: plug small mem leak
From __pmDecodeNameList() analysis after libpcp_pmda patch.
commit 441de74781e4313b750760ec3e48eb34580f99e6
Author: EC2 Default User <ec2-user@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Date: Fri May 15 21:01:18 2015 +0000
libpcp_pmda: Fixed a memory leak detected by valgrind.
commit 3b8a24dbdcf0835cdb72edcfcb8987e65f4d9d11
Author: Lukas Berk <lberk@xxxxxxxxxx>
Date: Thu May 7 18:49:33 2015 -0400
Wrap pcp-pmda-rpm and pcp-gui with proper %if checks
pcp-pmda-rpm and pcp-gui aren't built on some platforms,
wrapping them with proper checks so it doesn't fail on other platforms
commit 7e35f96431dcb6e913d017c1811b844e6d1268ef
Author: Lukas Berk <lberk@xxxxxxxxxx>
Date: Thu May 7 13:35:19 2015 -0400
Fix location of pcp-webjs gitweb in the pcp guide
commit ff6b1024f3dfcd03512fb55b1390582e0b58c9ee
Author: Lukas Berk <lberk@xxxxxxxxxx>
Date: Thu May 7 11:19:56 2015 -0400
spin-rawhide: Extract version info from VERSION.pcp
At times (specifically after a release), the spec file can become out
of sync with the VERSION.pcp. This tweak of spin-rawhide gets the
specific version info from the definitive source (VERSION.pcp).
|