pcp
[Top] [All Lists]

Re: [pcp] pcp updates: containers, qa

To: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Subject: Re: [pcp] pcp updates: containers, qa
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Wed, 13 May 2015 00:28:46 -0400 (EDT)
Cc: PCP <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <1582823694.18245416.1431484897421.JavaMail.zimbra@xxxxxxxxxx>
References: <1009828124.17466209.1431416607069.JavaMail.zimbra@xxxxxxxxxx> <5552B428.2010604@xxxxxxxxxx> <1582823694.18245416.1431484897421.JavaMail.zimbra@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: x4emiKMbvYNzJv1AktH9VZESub+k72AmbROS
Thread-topic: pcp updates: containers, qa

----- Original Message -----
> ----- Original Message -----
> > On 05/12/2015 05:43 PM, Nathan Scott wrote:
> > > Changes committed to git://git.pcp.io/nathans/pcp.git master
> > >
> 
> Ah - this looks like a different problem to PR1106.  I can see what it is
> likely to be though.

Can you try attached patch, see how it fares?  Lightly sanity tested only
at this stage.

> > Also noticed containers.state.running was showing way too many instances.
> > Should be zero or at most one ("docker ps" shows none running).
> 
> The indom is "all containers".  The metric value shows whether its running
> or not (0/1), so I suspect this is probably operating as designed - or are
> you saying they have value "1" when they shouldn't?

>From our chat, sounds like its fine as-is and "docker ps -a" output indeed
matches what we have.  Looking forward to hearing more about the profiling
run for pmdaroot with 1000s of containers too - thanks!

> > To repro, run the following :
> > [...]
> 
> This should be an automated test, verifying the failing case - could you
> Make It So while I prep a fix?  Taa.
> 

Lemme know if time is short & I'll prep something for qa from your earlier
recipe (tomorrow).

cheers.

--
Nathan

Attachment: missing-name.patch
Description: Text Data

<Prev in Thread] Current Thread [Next in Thread>