pcp
[Top] [All Lists]

Re: [pcp] pcp updates: containers, qa

To: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Subject: Re: [pcp] pcp updates: containers, qa
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue, 12 May 2015 22:41:37 -0400 (EDT)
Cc: PCP <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <5552B428.2010604@xxxxxxxxxx>
References: <1009828124.17466209.1431416607069.JavaMail.zimbra@xxxxxxxxxx> <5552B428.2010604@xxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: x4emiKMbvYNzJv1AktH9VZESub+k7w==
Thread-topic: pcp updates: containers, qa
Hi Mark,

----- Original Message -----
> On 05/12/2015 05:43 PM, Nathan Scott wrote:
> > Changes committed to git://git.pcp.io/nathans/pcp.git master
> >
> > Nathan Scott (3):
> >        pmdalinux: fix container issues, especially with networking metrics
> >        qa: fix typo in an error message in test 540
> >        build: extend gitignore file set for pmdaroot
> 
> The code all looks OK to me, but testing failed - pmdaroot segfault
> with a NULL cp->name in the fetch callback. This is with a script running
> that is continually creating busybox containers that basically just run
> ifconfig -a and then exit.

Ah - this looks like a different problem to PR1106.  I can see what it is
likely to be though.

> Also noticed containers.state.running was showing way too many instances.
> Should be zero or at most one ("docker ps" shows none running).

The indom is "all containers".  The metric value shows whether its running
or not (0/1), so I suspect this is probably operating as designed - or are
you saying they have value "1" when they shouldn't?

> To repro, run the following :
> [...]

This should be an automated test, verifying the failing case - could you
Make It So while I prep a fix?  Taa.

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>