pcp
[Top] [All Lists]

Re: [pcp] python 2.4 and qa issue

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Re: [pcp] python 2.4 and qa issue
From: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Tue, 05 May 2015 13:44:14 +1000
Cc: pcp developers <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <1986755467.12568716.1430789599666.JavaMail.zimbra@xxxxxxxxxx>
References: <005601d086d2$76624430$6326cc90$@internode.on.net> <1986755467.12568716.1430789599666.JavaMail.zimbra@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
On 05/05/15 11:33, Nathan Scott wrote:
...
What's the value of PCP_PYTHON_PROG from /etc/pcp.conf?  It should be
something like "python2.6" on el5 (the default 2.4 is too old). ..

kenj@vm04:~/src/pcp/qa$ grep PY /etc/pcp.conf
PCP_PYTHON_PROG=python
kenj@vm04:~/src/pcp/qa$ python -V
Python 2.4.3

The
test should be picking up that version in $python (via common.python),
instead of using 2.4.x, and the test program should then pass.

There is no Python 2.6 on this VM ...

kenj@vm04:~/src/pcp/qa$ rpm -qa | grep python | grep pcp
<no output>

So it appears the build guard is correct, but we're missing a notrun for the qa test ... does this look right?

kenj@vm04:~/src/pcp/qa$ git diff 995
diff --git a/qa/995 b/qa/995
index 007c67f..94e9199 100755
--- a/qa/995
+++ b/qa/995
@@ -9,6 +9,9 @@ seq=`basename $0`
 echo "QA output created by $seq"

 . ./common.python
+$python -c "from pcp import pmapi" >/dev/null 2>&1
+[ $? -eq 0 ] || _notrun "python pcp pmapi module not installed"
+
 status=1       # failure is the default!
 $sudo rm -rf $tmp.* $seq.full
 trap "cd $here; rm -rf $tmp.*; exit \$status" 0 1 2 3 15

<Prev in Thread] Current Thread [Next in Thread>