pcp
[Top] [All Lists]

Re: [pcp] Hotproc fixes

To: Nathan Scott <nathans@xxxxxxxxxx>, Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Subject: Re: [pcp] Hotproc fixes
From: Martins Innus <minnus@xxxxxxxxxxx>
Date: Thu, 30 Apr 2015 09:22:13 -0400
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <102929865.10042134.1430363515688.JavaMail.zimbra@xxxxxxxxxx>
References: <5536A934.8040002@xxxxxxxxxxx> <5537A154.2090803@xxxxxxxxxx> <5537A3F3.5060204@xxxxxxxxxxx> <233739221.5258413.1429764654377.JavaMail.zimbra@xxxxxxxxxx> <55392BAB.3060101@xxxxxxxxxxx> <806884984.5885784.1429839438565.JavaMail.zimbra@xxxxxxxxxx> <554128C1.8080901@xxxxxxxxxxx> <102929865.10042134.1430363515688.JavaMail.zimbra@xxxxxxxxxx>
User-agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
Nathan,

On 4/29/2015 11:11 PM, Nathan Scott wrote:
Also included some other cleanup suggestions from Marko, the ability to
reload the config file, updated qa hopefully for all the changes, merged
the manpage into procpmda, and added a new error code.  Feel free to
drop that last one if you think its unnecessary. It should be its own
commit.

I've left that last one for now - needs a bit more discussion I guess, as
an ABI extension.  I like it though.  We should probably audit the three/
four other PMDAs that already use PM_ERR_CONV and switch 'em over.

Sounds good.


Ken - any other thoughts on a specific error code for bad pmStore to a PMDA?
(Oh, maybe the name PM_ERR_BADSTORE to match your error message more closely
Martins?  the "FMT" part I found a little bit cryptic)
I like yours better, I was struggling for a good name.

Thanks

Martins

<Prev in Thread] Current Thread [Next in Thread>