pcp
[Top] [All Lists]

Re: [pcp] Hotproc fixes

To: Martins Innus <minnus@xxxxxxxxxxx>
Subject: Re: [pcp] Hotproc fixes
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Mon, 27 Apr 2015 19:54:43 -0400 (EDT)
Cc: myllynen@xxxxxxxxxx, pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <553D1EBD.9030603@xxxxxxxxxxx>
References: <5536A934.8040002@xxxxxxxxxxx> <5537A154.2090803@xxxxxxxxxx> <5537A3F3.5060204@xxxxxxxxxxx> <233739221.5258413.1429764654377.JavaMail.zimbra@xxxxxxxxxx> <55392BAB.3060101@xxxxxxxxxxx> <206370475.5905649.1429846876286.JavaMail.zimbra@xxxxxxxxxx> <553D1EBD.9030603@xxxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: i3730OBO40feQJpUP7bO1J0t5fy5MA==
Thread-topic: Hotproc fixes
Hi Martins,

----- Original Message -----
> Nathan,
> 
> On 4/23/2015 11:41 PM, Nathan Scott wrote:
> >
> > ----- Original Message -----
> >> [...]
> >> OK, tracked this down.  Only happens on some OSs.  I had assumed that
> >> all of /proc/<pid>/* should be available and files would only be missing
> >> if some badness happened or a pid was in the process of exiting.  Turns
> >> out that schedstat is not enabled in some kernels by default.  Will need
> >> a bit of rework to deal with this.
> > Now that I think about it, the /proc/pid/io entry is in the same boat...
> > the kernel fs/proc/base.c code has -
> >
> > #ifdef CONFIG_TASK_IO_ACCOUNTING
> >          ONE("io",       S_IRUSR, proc_tgid_io_accounting),
> > #endif
> >
> >
> Yup, probably also need the following guards, but I don't have a system
> without these entries to test for sure.
> 
> https://github.com/ubccr/pcp/tree/hotproc_cleanups

Good call, yes.  I also don't have such a system, but we can fake it via
$PROC_STATSPATH env var - I'm writing some other pmdaproc QA tests today,
will add this in at the same time.

cheers.

--
Nathan

<Prev in Thread] Current Thread [Next in Thread>