merged via Nathan.
Changes committed to git://git.pcp.io/pcp.git master
Nathan Scott (6):
qa: add to gitignore for lookupnametest binary
pmdamounts: fix stack corruption for large mount options
qa: update hotproc tests after martins latest set of fixes
python: exception handling improvements
qa: increase nap time in test 312 for slower QA boxen
qa: flush output streams in qa/995 for deterministic output
Ken McDonell (3):
qa/475: fallout from pmLookupName() rework
qa/444: pmLookupName() fallout
libpcp/pmns.c: pmNameID and pmNameAll change
Martins Innus (1):
hotproc - more cleanups
qa/312 | 2
qa/444 | 2
qa/444.out.1 | 14 ++-
qa/444.out.2 | 14 ++-
qa/444.out.3 | 14 ++-
qa/475.out | 30 ++++----
qa/800 | 8 +-
qa/800.out | 20 ++++-
qa/845 | 84 +++++++++++++++++++++++
qa/845.out | 45 ++++++++++++
qa/982.out | 2
qa/995 | 18 +++++
qa/995.out | 12 +++
qa/group | 3
qa/src/.gitignore | 1
qa/src/GNUlocaldefs | 3
qa/src/multithread9.c | 9 +-
qa/src/pmapi_exceptions.python | 57 ++++++++++++++++
src/libpcp/src/pmns.c | 5 +
src/pmdas/linux_proc/config.c | 2
src/pmdas/linux_proc/gram_node.c | 9 ++
src/pmdas/linux_proc/proc_pid.c | 6 +
src/pmdas/mounts/Install | 4 -
src/pmdas/mounts/Remove | 20 -----
src/pmdas/mounts/help | 27 ++-----
src/pmdas/mounts/mounts.c | 137 +++++++++++++++++++--------------------
src/pmdas/mounts/mounts.conf | 7 -
src/pmdas/mounts/pmns | 6 -
src/python/pcp/pmapi.py | 4 -
29 files changed, 402 insertions(+), 163 deletions(-)
Details ...
commit 0cb359346b445461202dfdbb5bbef3b937e152b5
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Fri Apr 24 16:05:37 2015 +1000
qa: flush output streams in qa/995 for deterministic output
commit 707f2de72c2886e968a7d91236e7e638473e1b6f
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Fri Apr 24 14:49:41 2015 +1000
qa: increase nap time in test 312 for slower QA boxen
commit 4ade898f26a9aa75ac10b1976673b0f0bb524786
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Fri Apr 24 13:06:16 2015 +1000
python: exception handling improvements
Ensure that the program name passed back from pmErr exception
class is a native string (not always bytes); add a pmUsageErr
extension allowing initial diagnostic message before Usage:
Adds qa/995 and a helper python script to exercise both of the
exception classes, using each mode of invocation.
commit 6b5394e99ffbe755babc8ee8342a8b1ff240036f
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Fri Apr 24 11:13:33 2015 +1000
qa: update hotproc tests after martins latest set of fixes
Values for the hotproc config metric now have braces, so a
couple of tests needed updating. Also tweaked the pmdaproc
config generation code so that this
> value "(uid == 0.000000)"
is once again reported as
> value "(uid == 0)"
commit 8bcc3e21eb8851c4c3e29c004be7ac3d1179106e
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Fri Apr 24 10:24:32 2015 +1000
pmdamounts: fix stack corruption for large mount options
MiloÅ found some scenarios where the mounts PMDA could crash
and burn when a machine has mounts with option strings larger
than the allocated space for them. This commit improves the
bounds checking for all arrays in this PMDA, and also does a
bit of general housecleaning for pmdamount readability. Test
qa/845 is added to exercise the mount PMDA.
Resolves RHBZ #1213833.
commit 2d3c11e3cb6611bca732742102596ed1e6eafd63
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date: Fri Apr 24 10:09:30 2015 +1000
qa: add to gitignore for lookupnametest binary
commit 6dc6f0a8d879882caa99648211f8b45196af4ecb
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Apr 24 09:28:18 2015 +1000
libpcp/pmns.c: pmNameID and pmNameAll change
Small error path logic change needed as a result of the last round of
changes for looking up the names of dynamic metrics ... found by some
QA failures.
commit b178b2ce679fa9da644ba280dc695fb0b7721be5
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Apr 24 09:25:04 2015 +1000
qa/444: pmLookupName() fallout
This time the client <--> pmcd protocol changed slightly but the
same output is generated thanks to compensating changes in libpcp.
Add a bit more PCP -Dderive diagnostic output to confirm that
the change is correct.
commit dbcd0970569018285b8deb7bc1714bd1dc0d9225
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Fri Apr 24 08:40:39 2015 +1000
qa/475: fallout from pmLookupName() rework
Tweak error handling in qa/src/multithread9.c, and a new 475.out
to match.
commit a6965ef0a68969e3e877884918491a30e1f6c45c
Author: Martins Innus <minnus@xxxxxxxxxxx>
Date: Thu Apr 23 19:35:29 2015 +0000
hotproc - more cleanups
Fix hotproc failing on linux kernel with no schedstat
Fix qa/800 to detect nprocs==0
Cleanup hotproc.control.config output
|