pcp
[Top] [All Lists]

Re: [pcp] pcp updates - pmLookupName()

To: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Subject: Re: [pcp] pcp updates - pmLookupName()
From: Martins Innus <minnus@xxxxxxxxxxx>
Date: Tue, 21 Apr 2015 20:39:02 -0400
Cc: "pcp@xxxxxxxxxxx" <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <5536E9EE.1060108@xxxxxxxxxxxxxxxx>
References: <5536E9EE.1060108@xxxxxxxxxxxxxxxx>
Thanks Ken!  I will test my previously failing cases Tommorrow.

Martins

> On Apr 21, 2015, at 8:23 PM, Ken McDonell <kenj@xxxxxxxxxxxxxxxx> wrote:
> 
> Changes committed to git://git.pcp.io/kenj/pcp master
> 
> Ken McDonell (1):
>      libpcp/pmns.c: pmLookupName() fix up
> 
> man/man3/pmlookupname.3 |   94 ++++++++++++++++-
> qa/404.out              |   12 +-
> qa/901.out              |   12 +-
> qa/909                  |  122 +++++++++++++++++++++++
> qa/909.out              |  131 ++++++++++++++++++++++++
> qa/group                |    1 
> qa/src/interp_bug.c     |   10 +
> qa/src/interp_bug2.c    |   22 +++-
> qa/src/lookupnametest.c |   53 +++++++++-
> qa/src/multifetch.c     |    3 
> qa/src/multithread5.c   |    5 
> qa/src/multithread6.c   |    5 
> qa/src/multithread7.c   |    5 
> qa/src/multithread8.c   |    5 
> qa/src/multithread9.c   |    5 
> qa/src/permfetch.c      |    2 
> qa/src/torture_api.c    |    6 -
> src/libpcp/src/pmns.c   |  252 
> +++++++++++++++++++++++++++++++++++-------------
> src/pmcd/src/dopdus.c   |   83 +++++++++------
> 19 files changed, 694 insertions(+), 134 deletions(-)
> 
> Details ...
> 
> commit d26ac520e34c42a07825864dc7db84b4bee300bf
> Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
> Date:   Wed Apr 22 10:17:33 2015 +1000
> 
>    libpcp/pmns.c: pmLookupName() fix up
> 
>    Complete audit of pmLookupName() error handling, to ensure we are
>    consistent across all of
>    - local PMNS (with and without a current context)
>    - remote host context
>    - local context
>    - archive context
>    for all types of metrics, but especially DYNAMIC metrics.
> 
>    Mostly in libpcp, but also a small pmcd change.
> 
>    pmLookupName() man page updated to reflect the real error handling
>    protocol and verified example code added.
> 
>    As a by-product, discovered that pmNameID() and pmNameAll() were
>    broken for DYNAMIC metrics, so drive-by fix for these as well.
> 
>    And finally a bunch of QA consequential cleanup.
> 
> _______________________________________________
> pcp mailing list
> pcp@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/pcp
> 
> 

<Prev in Thread] Current Thread [Next in Thread>