pcp
[Top] [All Lists]

.NeedInstall patch

To: pcp developers <pcp@xxxxxxxxxxx>
Subject: .NeedInstall patch
From: Martins Innus <minnus@xxxxxxxxxxx>
Date: Tue, 21 Apr 2015 09:10:13 -0400
Delivered-to: pcp@xxxxxxxxxxx
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
Hi,
ÂÂÂ I've been trying to debug a strange issue that the following patch seems to fix:

https://github.com/ubccr/pcp/tree/martins_working


The pmda setup process doesn't cd back to PCP_PMDA_DIR after processing a .NeedInstall file. This might not be the right solution though, because currently, at least with my testing (Centos 6.5), if you put a .NeedInstall file into multiple pmda directories, the first 2 get installed and not the rest. I would have thought only one would get installed with the current script. So not sure if there is something else going on here.

With this patch, all get installed.

Martins

commit 4588745c412196c1bd1b80e36afcee8276d6a658
Author: Martins Innus <minnus@xxxxxxxxxxx>
Date:ÂÂ Tue Apr 21 12:59:24 2015 +0000

ÂÂÂ Allow more than one .NeedInstall to occur at a time
ÂÂÂ
ÂÂÂ Chnage back to PCP_PMDAS_DIR after installing a pmda

Âsrc/pmcd/rc_pmcd |ÂÂÂ 1 +
Â1 files changed, 1 insertions(+), 0 deletions(-)



diff --git a/src/pmcd/rc_pmcd b/src/pmcd/rc_pmcd
index 6037534..edfdd2e 100644
--- a/src/pmcd/rc_pmcd
+++ b/src/pmcd/rc_pmcd
@@ -210,6 +210,7 @@ _pmda_enact()
 		$PCP_BINADM_DIR/pmpost "PMDA setup: automated $action FAILED (exit=$?): $pmda"
 		mv .Need$action.sav .Need$action
 	    fi
+	    cd "$PCP_PMDAS_DIR"
 	fi
     done
     # move back into PMDA dir as expected by _pmda_setup()

<Prev in Thread] Current Thread [Next in Thread>
  • .NeedInstall patch, Martins Innus <=