pcp
[Top] [All Lists]

[Bug 1067] linux pmda does too much work for network.interface queries

To: pcp@xxxxxxxxxxx
Subject: [Bug 1067] linux pmda does too much work for network.interface queries
From: bugzilla-daemon@xxxxxxxxxxx
Date: Sat, 11 Apr 2015 16:41:06 +0000
Auto-submitted: auto-generated
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <bug-1067-835@xxxxxxxxxxxxxxxx/bugzilla/>
References: <bug-1067-835@xxxxxxxxxxxxxxxx/bugzilla/>
changed bug 1067
What Removed Added
CC   michele@acksyn.org

Comment # 3 on bug 1067 from
Seems that when we call refresh_proc_net_dev(INDOM(NET_DEV_INDOM)) we then
unconditionally call:
...  
 /* Issue ioctls for remaining data, not exported through proc */
 memset(&netip->ioc, 0, sizeof(netip->ioc));
 if (refresh_net_dev_ioctl(p, netip) < 0)
     refresh_net_dev_sysfs(p, netip);
...

Those two functions do the whole ioctl/sysfs dance.
I assume we could cache the values we fill in those functions, namely:
netip->ioc.mtu
netip->ioc.linkup
netip->ioc.running
netip->ioc.speed
netip->ioc.duplex

Any other thoughts here?


You are receiving this mail because:
  • You are on the CC list for the bug.
<Prev in Thread] Current Thread [Next in Thread>