Hi,
Have taken on the advice from Nathan and have made the changes required
to pmdadm so that it has multiple top-level namespaces and along with
that compatible metric names with the currently released version of the
dm-cache PMDA.
Have also added the missing dmcache.io_modes_code metric along with
updating the qa test for the PMDA.
Changes committed to git://github.com/pauljevans/pcp.git master
qa/657 | 6 +-
qa/657.out | 189
+++++++++++++++++++++++++------------------------
src/pmdas/dm/Install | 2 +-
src/pmdas/dm/Remove | 3 +-
src/pmdas/dm/dmcache.c | 6 +-
src/pmdas/dm/dmcache.h | 2 +
src/pmdas/dm/help | 59 +++++++--------
src/pmdas/dm/pmda.c | 8 ++-
src/pmdas/dm/pmns | 53 +++++++++-----
src/pmdas/dm/root | 4 +-
10 files changed, 186 insertions(+), 146 deletions(-)
commit 7ad481fffe0bd6a14ffcda4ab5d57d9a5c3f499f
Author: Paul Evans <pevans@xxxxxxxxxx>
Date: Tue Mar 31 18:30:36 2015 +0100
pmdadm: Make use of pmdaproc.sh to keep previous metric names
Updates to the metrics names for pmdadm so that it makes use of the
previous metric names for dmcache and dmthin. These changes make use
of pmdaproc.sh to have multiple top-level namespace names as
suggested by Nathan Scott.
Have also added a previously missed metric dmcache.io_mode_code in
order to keep parity with the older python dmcache PMDA. The qa/657
script has also been updated to reflect these changes to the PDMA.
Code tested and checked with Coverity and has no reported issues.
The patch has been tested and has had covscan run on it. As always
please let
me know if there are any issues and as always feedback is welcome :).
Cheers,
Paul
|