Hi Paul,
----- Original Message -----
> Hi,
>
> I have been working towards adding coverage for thin-provisioning (dm-thin)
> to PCP to compliment the already existing dm-cache coverage. Please find
> below the initial version of a dmthin PMDA for review/inclusion, likewise
> with the dmcache PMDA this makes use of the dmsetup tool's status switch
> for the targets thin-pool and thin.
>
Looks good to me. I fixed a few trivial comment typos before merging. One
larger change you might consider would be to make the QA injection happen via
a command rather than just a file name (e.g. DMTHIN_STATSCMD="/bin/cat $f").
That would allow removal of the conditional code in the PMDA fetch/instance
routines - IOW, it would always be able to use popen then (evaluate that env
variable once in dmthin_init, then use the overridden command throughout via
global pointer to the command-to-run, defaulting to dmsetup instead of cat).
cheers.
--
Nathan
|