On 10/03/15 01:04, Frank Ch. Eigler wrote:
...
No big deal, but why are PDUs multiples of an int? It may matter for
the archive format, but for network & other temporary purposes, does
the multiples-of-an-int property carry any benefit?
On some architectures there is benefit from the fields _within_ a PDU
being word aligned. But there is no real reason for the PDU to be
padded to a word boundary in the rare cases where the PDU does not end
with an integer. However that's the way it is, and for compatibility I
think we're stuck with it staying that way.
Most of the PDUs are not used at all for archive contexts, and in
particular the PMNS ones at the center of this discussion are not
relevant to archives.
...
(Just that the qa/367{,.out} files assert '~' padding in a bunch of
places.)
Ah, thanks.
...
Righto, thanks for the pointer. Please see pcpfans.git
Good.
I've cherrypicked this commit into my tree and reviewed. It looks fine
and is relevant for _any_ pdubuf implementation, so I'll push it up
stream after some QA soak (it already passes -g libpcp on one platform).
Thanks, Frank.
|