Hi, Lukas -
> [...] How about the following small patch in addition to yours? It
> removes any warnings on startup, as we don't enable all the metrics
> we probe initially, and then returns the default to 120 seconds.
The effect of that patch would be not only to just disable auto-enable
during the initial pmda install, but on every subsequent pmcd restart.
That's harsh.
> The qa would need updating again, which I can provide. I would also
> like to remove the phrasing that warnings are reasonable in the
> testsuite, imo in this case, they aren't.
The warnings in this case are apropos: some counter values are just
not available for the asking. By turning auto-enable off during
install, as in your patch, this fact is obscured from the
pmprobe/user, because then no counters are even attempted to be used!
If the point of the pmdaInstall "pmprobe -i" is to exercise the pmda,
then let's exercise it.
> On a side note, I'm not sure what the changes in pmdapapi.1 are
> supposed to mean? Are they mistakes? "#true -- ..." ?
They're just comments, explaining each command. They're executable,
in case a user copy&pastes that section of the man page into a shell.
- FChE
|