Re: [pcp] pmcd dumps core on containers test

[Nathan Scott <nathans@xxxxxxxxxx>]

----- Original Message -----
> [...]
> Digging further, with all of the rest of libpcp_pmda compiled -O2, the
> problem appears and disappears depending on whether pduroot.c is compiled
> -O2 or not.

Oh wow, thanks for the detailed analysis & insight!!

> Hmm ... pduroot.c seems benign, but wait ... pduroot.h contains the pdu
> buffer typedef with a name[0] field ... this looks like a smoking gun.  If
> -O2 is confused by the pointer assignment and thinks pdu->name is of size 0
> and then checks before doing the inlined strncpy, then maybe KABOOM.
> 
> A small rework of pduroot.h and associated code in pduroot.c and we're
> laughing ... all the container QA tests pass.

Good stuff - thanks again Ken!

cheers.

--
Nathan