pcp
[Top] [All Lists]

Re: interp3.c vs valgrind qa fallout

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Re: interp3.c vs valgrind qa fallout
From: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date: Wed, 11 Feb 2015 07:01:21 +1100
Cc: "pcp@xxxxxxxxxxx >> PCP" <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <1786689886.2028682.1423566664005.JavaMail.zimbra@xxxxxxxxxx>
References: <1786689886.2028682.1423566664005.JavaMail.zimbra@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
Yep.

My previous "fix" just morphed the valgrind errors, not removed them as I'd hoped ... in my tree there is an updated fix which I'm just giving some QA love before I advertise it as ready to be pushed.

Thanks and apologies.

On 10/02/15 22:11, Nathan Scott wrote:
Hi Ken,

I'm running your latest dev with pmdaproc.sh speedup ... seeing the
attached qa fail - just FYI.  I'm not seeing any likely libpcp cause
so I'm punting this change is behind it at this stage:

commit 641cefaa599a66e55e2faf741581483dc1091650
Author: Ken McDonell <kenj@xxxxxxxxxxxxxxxx>
Date:   Tue Feb 10 12:17:34 2015 +1100

     qa/src/interp3.c: free() the *alloc()s from main

     Avoids confusing valgrind in some places, like vm25 (x86_64
     CentOS 5.5).

Lemme know if its not ringing a bell & I'll dig further.

cheers.

--
Nathan


<Prev in Thread] Current Thread [Next in Thread>