diff --git a/MANIFEST.in b/MANIFEST.in index 239115f..3235fd0 100644 --- a/MANIFEST.in +++ b/MANIFEST.in @@ -2,4 +2,3 @@ include COPYING include src/pcp2pdf.bash include src/pcp2pdf.conf include src/pcplogo.png -include man/pcp2pdf.1 diff --git a/README.md b/README.md index 77d36c8..a67b72b 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ -This document is meant to give an introduction to `pcp2pdf` +This document gives an introduction to `pcp2pdf` What is pcp2pdf for? ==================== @@ -8,13 +8,22 @@ The main goal of pcp2pdf is to create a visually pleasing report of a contain a bunch of metrics of a system and are usually created by the pmlogger service, which is part of `Performance Co-Pilot`. +Prerequisites +============= + +pcp2pdf is a python program and makes use of these 3rd party modules: + +- [matplotlib](http://matplotlib.org/users/installing.html) +- [reportlab](http://www.reportlab.com/opensource/) + Installation ============ + If you're using Fedora, you can use the packages found [here](http://acksyn.org/files/rpms/pcp2pdf/). Otherwise just use the following: ./setup.py install - pcp2pdf + pcp2pdf --help Usage examples ============== diff --git a/src/pcp2pdf.egg-info/SOURCES.txt b/src/pcp2pdf.egg-info/SOURCES.txt index 5f5e95f..8452978 100644 --- a/src/pcp2pdf.egg-info/SOURCES.txt +++ b/src/pcp2pdf.egg-info/SOURCES.txt @@ -2,7 +2,6 @@ COPYING MANIFEST.in setup.cfg setup.py -man/pcp2pdf.1 src/pcp2pdf.bash src/pcp2pdf.conf src/pcplogo.png diff --git a/src/pcp2pdf/archive.py b/src/pcp2pdf/archive.py index b90b987..faba266 100644 --- a/src/pcp2pdf/archive.py +++ b/src/pcp2pdf/archive.py @@ -172,7 +172,6 @@ class PcpArchive(object): # indom_map is just used as an optimization. The keys are (numpmid, # numinst) and the value is the indom name. This avoids too many # expensive calls to pmNameInDomArchive. - # FIXME: is this guaranteed to never brake? indom_map = {} metrics = self.get_metrics() pmids = self.get_pmids(metrics) @@ -209,7 +208,7 @@ class PcpArchive(object): if metric not in data: data[metric] = {} count = result.contents.get_numval(i) - if count == 0: # No instance whatsover + if count == 0: # No instance whatsoever continue elif count == 1: # No indoms are present try: