Re: pcp updates: pmdaproc, cgroups, books

["Frank Ch. Eigler" <fche@xxxxxxxxxx>]

Hi -


> ----- Original Message -----
> > [...]
> > Yes, except that pmval is limited to a single metric per invocation.
> > A single "pminfo cgroup" run can exercise all metrics, and "pminfo
> > cgroup cgroup cgroup ..." can endurance-test all metrics, not just the
> > one that we found/fixed this leak in, so it's more forward-looking.
> 
> This is trivially tackled as in test qa/957 and results in a better
> test - that one even points out which cluster the pmdalinux bugs it
> finds are in (done that way on purpose, to save diagnosis time)!

Valgrind is fine, but does not provide sufficient coverage to catch
all instances of this kind of problem.


> [...]  Either I'm missing something, or you're missing what is
> happening in proc_refresh - it doesn't matter how many PMIDs get
> thrown at a single fetch, it will refresh each cluster only once per
> fetch...  so it has to be the fetch batching that triggers the leak,
> right?

Did you run the test I posted?  I included results (taken before and
after the fd-leak patch) that speak for themselves, and don't rely on
speculation about what internal behaviors should have or not have
triggered the bug.


- FChE