pcp
[Top] [All Lists]

Re: [pcp] Dynamic metric rework

To: Martins Innus <minnus@xxxxxxxxxxx>
Subject: Re: [pcp] Dynamic metric rework
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Tue, 16 Dec 2014 06:33:18 -0500 (EST)
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <548F451F.7000606@xxxxxxxxxxx>
References: <5481E4D7.8050700@xxxxxxxxxxx> <548897F5.4010905@xxxxxxxxxxx> <1194215403.14908758.1418289588303.JavaMail.zimbra@xxxxxxxxxx> <5489F5D1.6050208@xxxxxxxxxxx> <668428007.16198533.1418365513812.JavaMail.zimbra@xxxxxxxxxx> <548B46B3.10407@xxxxxxxxxxx> <372975962.17650087.1418622822222.JavaMail.zimbra@xxxxxxxxxx> <548F451F.7000606@xxxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: Nw0knUDA/bLqLgW6GbxWtq4sDKET6A==
Thread-topic: Dynamic metric rework
Hi Martins,

Oh - this test has a dependence on the number of CPUs on the
test machine, I missed that earlier.  We could either filter
so that we check the percpu inst count matches hinv.ncpu, or
maybe we could use $LINUX_STATSPATH to setup a deterministic
output?  (bit like tests 732, 747 or 885)

cheers.

----- Original Message -----
> Nathan,
> 
> On 12/15/14 12:53 AM, Nathan Scott wrote:
> >
> > Looks good, thanks Martins.  Do you want to add this to your working
> > branch?
> > And where did we get up to with hotproc - are you happy with that & ready
> > to
> > merge?  (could you send me the git URL for the latest version of that code,
> > if so?)
> >
> commit 6cb6b341e5a3d0dd37011ee79ecc9a5194b0ac1f
> Author: Martins Innus <minnus@xxxxxxxxxxx>
> Date:   Mon Dec 15 15:26:44 2014 -0500
> 
>      Add qa test 955
>      Test that mixing fetches for static and dynamic metrics work as
> expected
>      The first test replicates a failure from a bug introduced during
> dymanic metric core changes
> 
>   qa/955     |   84
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
>   qa/955.out |   44 +++++++++++++++++++++++++++++++
>   qa/group   |    1 +
>   3 files changed, 129 insertions(+), 0 deletions(-)
> 
> 
> 
> This qa test is in martins_working.  Hotproc is pretty close. Writing a
> qa test now.
> 
> Thanks
> 
> Martins
> 

<Prev in Thread] Current Thread [Next in Thread>