Re: [pcp] RFC pcp update: pmParseUnitsStr() function

[Nathan Scott <nathans@xxxxxxxxxx>]

----- Original Message -----
> Hi -
> 
> > >Evidently yes, they're all over the code base.
> 
> > Sorry, I should have been more direct with that comment. As a matter of
> > style, we should have these kinds of comments only in C++ code.
> 
> OK, but
> 
>    % git grep "//" -- "*.c"
> 
> over the source tree shows many C files with this C99-compliant notation.

FWIW, I agree with Dave - always follow the style of the code being changed.
e.g. libpcp is all C-style comments (barring one silly TODO comment :) - heh
and thats in interp.c so noones game to touch it I guess!)

> > Can you please convert the ones in this code?
> 
> Changed.
> 
> > As we notice other instances, we should fix them as well.
> 
> Would you like a patch for the other 1200+ instances in the code base?

Just use the style that matches the code being modified (the other places
are isolated - like specific C PMDAs where the author chose to prefer //
style comments - and that's fine, we follow that style if modifying that
code).

thanks.

--
Nathan