pcp
[Top] [All Lists]
<prev [Date] next>
[Advanced]
 <prev [Thread] next>

Re: [pcp] RFC pcp update: pmParseUnitsStr() function

from [Dave Brolley] [Permanent Link][Original]
To: "Frank Ch. Eigler" <fche@xxxxxxxxxx>
Subject: Re: [pcp] RFC pcp update: pmParseUnitsStr() function
From: Dave Brolley <brolley@xxxxxxxxxx>
Date: Mon, 15 Dec 2014 10:40:57 -0500
Cc: pcp developers <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <20141212212048.GE14953@xxxxxxxxxx>
References: <20141201154517.GK5088@xxxxxxxxxx> <548B491B.1030705@xxxxxxxxxx> <20141212212048.GE14953@xxxxxxxxxx>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0 
HI Frank,

Thanks for the rework!

On 12/12/2014 04:20 PM, Frank Ch. Eigler wrote:

[...]
  * Are // style comments accepted by the C compilers on all the
    platforms we support?

Evidently yes, they're all over the code base.
Sorry, I should have been more direct with that comment. As a matter of style, we should have these kinds of comments only in C++ code. Can you please convert the ones in this code? As we notice other instances, we should fix them as well. 

Thanks,
Dave
[More with this subject...]
<Prev in Thread] Current Thread [Next in Thread>
Previous by Date:  Re: pcp updates: pmdaproc, cgroups, books, Nathan Scott
Next by Date:  Re: [pcp] RFC pcp update: pmParseUnitsStr() function, Frank Ch. Eigler
Previous by Thread:  Re: [pcp] RFC pcp update: pmParseUnitsStr() function, Frank Ch. Eigler
Next by Thread:  Re: [pcp] RFC pcp update: pmParseUnitsStr() function, Frank Ch. Eigler
Indexes:  [Date] [Thread] [Top] [All Lists]