Hi Jan-Frode,
----- Original Message -----
> On Mon, Dec 08, 2014 at 04:23:32AM -0500, Nathan Scott wrote:
> > ----- Original Message -----
> > > This adds a PMDA for the Unbound DNS resolver. Currently exposing 140
> > > metrics gathered from Unbounds "unbound-control stats" command. It's
> > > missing the per thread metrics, but I plan on adding these at a later
> > > point.
> > >
> >
> > Looks good - its merged now with a few additions (tests, build) - could
> > you check the merge & review git commit 31e2555c for me please?
>
> Thanks for merging, much appreciated.
No problem at all, thanks for contributing!
> I've looked trough the qa script, but I don't really understand how the
> qa tests works..., and don't feel qualified enough to give any input
> here.
That's OK - I should have given some more details - there's a file in the
PCP git tree (HACKING) and a qa/README file which describe the goals and
the overall process in a bit more detail.
>From a high-level though, each QA test is just a shell script. When run,
each test produces output; that output is then compared to saved, expected
output - if it matches it passes, if not it fails. That's about the level
of complexity involved - however within that so-simple framework there is
amazing scope for testing complexity!
cheers.
--
Nathan
|