Nathan,
Thanks for the review.
On 12/8/14 7:16 PM, Nathan Scott wrote:
S'fine by me. Since its no longer static, we should rename it to follow
the PMDA library externally-visible-symbols conventions - (no double __,
for both function and data structure names - the latter is covered, but
do the former too). src/libpcp_pmda/src/exports will also need tweaking.
I assume you mean add a new version (PCP_PMDA_3.4) at the bottom for
this new export?
I'm seeing a QA failure in test 660 - pmwebd is not seeing all of the names
for the interrupts metrics... (need to edit src/test_webapi.py to add debug
statements back in - commented out - this test needs some love to make it a
bit easier to diagnose these kinds of problems).
Is that one failing for you? If not, I can dig more - I guess its not in
either of those two test groups (linux/proc) above.
Yeah, I wasn't building pmwebd on this host. Got that up and running.
Looks like the error is coming from:
pmwebapi.cxx -> metric_list_traverse
The call to pmLookupDesc is failing on dynamic metrics. But the PMNS has
already been traversed successfully for them. Ran out of time today, I
will dig deeper tomorrow. My guess is I missed a call to populate the
metric table for some case.
I assume there is some order that is different in terms of what the
web-api does from the standard command line tools. pminfo/pmval appear
to work fine.
Thanks
Martins
|