pcp
[Top] [All Lists]

Re: [PATCH] Add PMDA for the Unbound DNS resolver.

To: Jan-Frode Myklebust <janfrode@xxxxxxxxx>
Subject: Re: [PATCH] Add PMDA for the Unbound DNS resolver.
From: Nathan Scott <nathans@xxxxxxxxxx>
Date: Mon, 8 Dec 2014 04:23:32 -0500 (EST)
Cc: pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <20141206110717.GA13661@xxxxxxxxxxxxxxxxx>
References: <20141127104047.GA7900@xxxxxxxxxxxxxxxxx> <20141206110717.GA13661@xxxxxxxxxxxxxxxxx>
Reply-to: Nathan Scott <nathans@xxxxxxxxxx>
Thread-index: terhbRCj2zhYvVNjN47ess8AeE8yHw==
Thread-topic: Add PMDA for the Unbound DNS resolver.
Hi Jan-Frode,

----- Original Message -----
> This adds a PMDA for the Unbound DNS resolver. Currently exposing 140
> metrics gathered from Unbounds "unbound-control stats" command. It's
> missing the per thread metrics, but I plan on adding these at a later
> point.
> 

Looks good - its merged now with a few additions (tests, build) - could
you check the merge & review git commit 31e2555c for me please?

thanks!


commit 31e2555c4ce127a84840d2ab9b3de98beb15dfad
Author: Nathan Scott <nathans@xxxxxxxxxx>
Date:   Mon Dec 8 17:51:08 2014 +1100

    pmda unbound: add initial tests for Unbound DNS resolver PMDA
    
    This adds two tests for the new Unbound DNS resolver PMDA - one to
    exercise the metric values being extracted from the unbound-control
    command output, the other to exercise the Install/Remove process.
    Found and fixed a bug in the latter, where an exception would be
    raised if the executed command did not exist.
    
    Also added a makefile for the unbound PMDA and generally stitched
    it into the build/packaging, ready for the next release.


--
Nathan

<Prev in Thread] Current Thread [Next in Thread>