pcp
[Top] [All Lists]

Bug#772352: pcp-testsuite: bashism in /bin/sh script

To: maintonly@xxxxxxxxxxxxxxx
Subject: Bug#772352: pcp-testsuite: bashism in /bin/sh script
From: Raphael Geissert <atomo64@xxxxxxxxx>
Date: Sat, 06 Dec 2014 15:18:11 +0100
Delivered-to: pcp@xxxxxxxxxxx
Delivered-to: maintonly@xxxxxxxxxxxxxxx
Dkim-signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:subject:date:message-id:mime-version :content-transfer-encoding:content-type:user-agent; bh=BXX8FvUml4yfcrOA+4hB/tlNnpNFzffr8beKZVxcwWc=; b=PYEdIcI0alJfbR9eBczPRNqLS+nD48QW8Tu015+M8RiiZXYcCePvjbdhbHSf/CH5cD 78Gn0huGFMIbgdKqV3tsM6Qf45HjfuhGscZ2ohGPk/rT5VGPQFiAhrtqq42Iqx4l9u+7 Czn4DV2AcwzeFMZQ6V9XHfhpLugVff2s42LQahTXNJg1LOAc7XlOjy0GFFuTrp/Kn05Z kO2YBCjqvQqrOhTZ5ezJx6zJ+aMUUB8IJIOtxE2EUoSlIfspNAmwiPNE6LdgHQeCdBVF +aM3GWbHwBLU8QGn9ICR88ZRoFk/ZS0q7GlluBHGPR/qZq9vr5wernx+pl9+ZjENUsUN YCMQ==
Reply-to: Raphael Geissert <atomo64@xxxxxxxxx>, 772352-maintonly@xxxxxxxxxxxxxxx
Resent-date: Sat, 06 Dec 2014 14:39:37 +0000
Resent-from: Raphael Geissert <atomo64@xxxxxxxxx>
Resent-message-id: <handler.772352.M.14178765441338@xxxxxxxxxxxxxxx>
Resent-to: PCP Development Team <pcp@xxxxxxxxxxx>
User-agent: KMail/1.13.7 (Linux/2.6.38; KDE/4.8.4; i686; ; )
Package: pcp-testsuite
Severity: important
Version: 3.10.1
User: debian-release@xxxxxxxxxxxxxxxx
Usertags: goal-dash

Hi,

I've ran checkbashisms (from the 'devscripts' package) over the whole
archive and I found that your package has a /bin/sh script that uses a
"bashism".

checkbashisms' output:
> possible bashism in ./var/lib/pcp/testsuite/751 line 19 (echo -e):
>     echo -e 'log mandatory on once {
> possible bashism in ./var/lib/pcp/testsuite/751 line 42 (echo -e):
> echo -e "\nold -> new changes"
> possible bashism in ./var/lib/pcp/testsuite/180 line 72 (time):
> (time pmval -z -n $tmp.pmns -a $arch -t $DELTA foo) >$tmp.out 2>$tmp.err
> possible bashism in ./var/lib/pcp/testsuite/180 line 82 (time):
> (time pmval -z -i 4653127 -n $tmp.pmns -a $arch -t $DELTA foo) >$tmp.out
> 2>$tmp.err


Not using bash (or a Debian Policy compliant shell interpreter that doesn't
provide such an extra feature) as /bin/sh is likely to lead to errors or
unexpected behaviours. Please be aware that dash is the default /bin/sh.

Please closely examine the above output and the script, and determine
what the proper severity of the bug is, and adjust it accordingly. If
it's important or greater please hurry to get this fixed for jessie.

Hints about how to fix bashisms can be found at:
https://wiki.ubuntu.com/DashAsBinSh

Thanks in advance,
Raphael Geissert

<Prev in Thread] Current Thread [Next in Thread>