pcp
[Top] [All Lists]

pcp updates: fix hinv.map.scsi buffer overrun and indom persistence issu

To: pcp@xxxxxxxxxxx
Subject: pcp updates: fix hinv.map.scsi buffer overrun and indom persistence issues
From: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date: Fri, 05 Dec 2014 19:35:24 +1100
Delivered-to: pcp@xxxxxxxxxxx
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.2.0

Sorry haven't had time to write QA for this yet - I'll do that when
I get back (10 days away). I've manually tested it with scsi_debug
with more than 2000 scsi devices, and assorted random hotplug/unplugging,
but only on RHEL7 so far.

Changes committed to git://git.performancecopilot.org/markgw/pcp/pcp.git dev

commit 738a3948c6439c2f76b1eca01e82fa7770216a03
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date:   Fri Dec 5 19:26:32 2014 +1100

    Remove support for devfs device names - replaced by udev.

            modified:   src/pmdas/linux/proc_partitions.c
            modified:   src/pmdas/linux/proc_scsi.c

commit 4f3e4f2c37960e88a80185cb12af0fd1e1f3fd37
Author: Mark Goodwin <mgoodwin@xxxxxxxxxx>
Date:   Fri Dec 5 19:27:48 2014 +1100

    Rework hinv.map.scsi for longer scsi device names and indom persistence.

    The scsi device map instance domain for hinv.map.scsi was originally written
    before scsi hotplug/unplug was widely supported, and (worse) didn't handle
    sd device names beyond sdz, causing buffer overruns. This update converts it
    to use the pmdaCache API for persistence and with arbitrary dynamic instance
    domain updates (both hotplug and unplug), and with any number of scsi 
devices.

        modified:   src/pmdas/linux/pmda.c
        modified:   src/pmdas/linux/proc_scsi.c
        modified:   src/pmdas/linux/proc_scsi.h


<Prev in Thread] Current Thread [Next in Thread>
  • pcp updates: fix hinv.map.scsi buffer overrun and indom persistence issues, Mark Goodwin <=