Hi David,
----- Original Message -----
> On 11/25/2014 02:33 PM, David Smith wrote:
> > On 11/24/2014 04:46 PM, David Smith wrote:
> >> On 11/23/2014 05:38 PM, Nathan Scott wrote:
> >>> Hi David,
>
> ... stuff deleted ...
>
> >>> Odd. Only thing I can think of is a python version difference - I'm
> >>> using RHEL6 on my primary test machine, which has a relatively old
> >>> python version. I'll have another go and look more deeply into the
> >>> failures.
> >>
> >> Hmm, I'll try running this code on RHEL6 (instead of F20) and see what I
> >> get.
> >
> > I'm seeing failures on RHEL6 also, digging into it now.
>
> Fixed in commit de90566 in the dsmith/dev branch of pcpfans.git. The
> ctypes.Structure class on python 2.6 only supported the older python
> buffer interface. The code handles both the older and newer buffer
> interfaces now.
Good stuff! Could you make a clean branch (maybe even a rebase and
just one/two logical commits) to pull from? I had a quick look and
got some conflicts on src/pmns/stdpmns.pcp - I think there's all of
your other WIP code (json) in dsmith/dev too still, isn't there?
I'd be happy pulling this initial PMDA wrapper work in now, with the
assumption that there'll be a PMDA & tests following that exercises
that new API. And we're early in the release cycle, so it's a good
time to merge this now.
cheers.
--
Nathan
|