Hi,
It was mentioned in the last developers meeting that there is CIFS
kernel code available that currently is not being exported in PCP.
To add this coverage into PCP I have made an initial version of a CIFS
PMDA for general review/inclusion and suggestions. This PMDA makes use
of statistics exported from procfs (/proc/fs/cifs/Stats).
Changes committed to git://github.com/pauljevans/pcp-cifs.git dev
qa/656 | 58 ++++++
qa/656.out | 302 +++++++++++++++++++++++++++
qa/GNUmakefile | 2 +-
qa/cifs/GNUmakefile | 15 ++
qa/cifs/GNUmakefile.install | 1 +
qa/cifs/cifs-root-2014-11-25.tgz | Bin 0 -> 543 bytes
qa/group | 1 +
src/pmdas/GNUmakefile | 2 +-
src/pmdas/cifs/.gitignore | 4 +
src/pmdas/cifs/GNUmakefile | 61 ++++++
src/pmdas/cifs/Install | 30 +++
src/pmdas/cifs/README | 64 ++++++
src/pmdas/cifs/Remove | 24 +++
src/pmdas/cifs/help | 136 +++++++++++++
src/pmdas/cifs/pmda.c | 429
+++++++++++++++++++++++++++++++++++++++
src/pmdas/cifs/pmdacifs.1 | 67 ++++++
src/pmdas/cifs/pmdacifs.h | 41 ++++
src/pmdas/cifs/pmns | 58 ++++++
src/pmdas/cifs/root | 9 +
src/pmdas/cifs/stats.c | 195 ++++++++++++++++++
src/pmdas/cifs/stats.h | 71 +++++++
21 files changed, 1568 insertions(+), 2 deletions(-)
commit 5606ce87e5a2d249efc0fd5e312c73c7f79b3c9b
Author: Paul Evans <pevans@xxxxxxxxxx>
Date: Wed Nov 26 18:39:45 2014 +0000
pmdacifs: Initial PMDA Code
Inital CIFS PMDA code using the stats given in procfs (DSO and Daemon),
using previously reserved domain 121.
Exports statistics from the /proc/fs/cifs/Stats file. In this initial
version we make use of the stats given globally for the cifs module
along with data provided per each mounted cifs share.
Requires at least the cifs kernel module to be loaded in order to
give the global cifs metrics and with each mounted cifs share comes
it's own instance of metrics.
QA is given with qa/656 which runs the pmda in DSO mode with a fake
root given (borrowed from xfs pmda getenv()) to provide testing data
instead of needed mounted cifs shares on the qa host. Also running
with valgrind during the test.
Code checked with coverity and has no reported issues.
All of the patches have been tested and have had covscan run on them. As
always please let me know if there are any issues and feedback is
welcome :).
Cheers
Paul
|