On 11/19/2014 03:29 AM, Nathan Scott wrote:
> Hi David,
>
> ----- Original Message -----
>> On 11/17/2014 04:53 PM, Nathan Scott wrote:
>>> Oh, I just had the impression from your earlier mail you weren't
>>> completely satisfied that we'd covered off all the cases ... its
>>> likely I've just misinterpreted that "except for [1]" reference.
>>
>> I believe I've covered all the cases. All list/dictionary references are
>> cached down in cpmda and no longer thrown away after use (a). In the
>> PMDA class, I made sure all lists/dictionaries are cleared, not recreated.
>>
>
> OK, good stuff. Do you want to merge the PMDA API changes at this
> stage?
>
> I tried cherry-picking (there's lots of other commits in dsmith/dev):
> cec13bfd0297ecc755265ba2db69a86daf32a05c
> f2f5a51cde0646fcdf35bc2f60798024c0931c9e
> 1fc0bbf9d517810e8512fb3a7775b68fc6f64572
> ... but there was a fair few test failures (I haven't dug deeper yet -
> they all look like python PMDAs failing to start or exiting early on,
> from a quick glance).
OK, I've tested this. I cherry-picked the following 3 commits from the
pcpfans.git dsmith/dev branch to a local copy of the pcpfans.git dev branch.
====
commit b2e3b5cdd15ddbe57c14b2eaa04cfbfebe2e190b
Author: David Smith <dsmith@xxxxxxxxxx>
Date: Fri Nov 14 15:03:20 2014 -0600
Improve pcp python support by simplifying refresh metrics callback.
commit 4a265214337a5313466fdd7586f00bdefc417f2c
Author: David Smith <dsmith@xxxxxxxxxx>
Date: Tue Nov 11 16:29:56 2014 -0600
Removed dead/unused code from src/python/pmda.c
commit 38983a531d83544d3f5d8c73348d0a7c543e90e8
Author: David Smith <dsmith@xxxxxxxxxx>
Date: Wed Oct 29 12:58:40 2014 -0500
Improve pcp python support by adding refresh metrics callback.
====
I ran all the qa tests before and after the cherry pick, and saw passes
both ways. The python "simple" pmda seems to work fine also.
I'm not sure why your commit ids are different than mine.
> Or, do you want to wait for that JSON PMDA to be closer to complete so
> we have at least one use case for the API? (either that or some form
> of specialised API test case will be needed - a real PMDA is probably
> easiest, with its tests covering use of the new API).
The latest version of the stap_json PMDA on the dsmith/dev branch, while
not finished does use the new refresh_metrics API.
I'm flexible on how we proceed here, we can do whatever you think makes
the most sense.
--
David Smith
dsmith@xxxxxxxxxx
Red Hat
http://www.redhat.com
256.217.0141 (direct)
256.837.0057 (fax)
|