pcp
[Top] [All Lists]

Re: pcp updates - pmdapapi update

To: Nathan Scott <nathans@xxxxxxxxxx>
Subject: Re: pcp updates - pmdapapi update
From: fche@xxxxxxxxxx (Frank Ch. Eigler)
Date: Mon, 17 Nov 2014 15:54:01 -0500
Cc: Lukas Berk <lberk@xxxxxxxxxx>, pcp@xxxxxxxxxxx
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <50063157.14443613.1415955185726.JavaMail.zimbra@xxxxxxxxxx> (Nathan Scott's message of "Fri, 14 Nov 2014 03:53:05 -0500 (EST)")
References: <87oascow3f.fsf@xxxxxxxxxx> <50063157.14443613.1415955185726.JavaMail.zimbra@xxxxxxxxxx>
User-agent: Gnus/5.1008 (Gnus v5.10.8) Emacs/21.4 (gnu/linux)
nathans wrote:

> [...]  - As per earlier mail, there's no error handling for auto-fu
> counters. [...]

Does this cover the case?

diff --git a/src/pmdas/papi/papi.c b/src/pmdas/papi/papi.c
index 15e224150704..86f38146e197 100644
--- a/src/pmdas/papi/papi.c
+++ b/src/pmdas/papi/papi.c
@@ -645,7 +645,9 @@ papi_fetchCallBack(pmdaMetric *mdesc, unsigned int inst, 
pmAtomValue *atom)
                 if (auto_enable_time) {
                     // auto-enable this metric for a while
                     papi_info[idp->item].metric_enabled = now + 
auto_enable_time;
-                    refresh_metrics();
+                    sts = refresh_metrics();
+                    if (sts < 0)
+                        return sts;
                 }
                return PMDA_FETCH_NOVALUES;
             }


- FChE

<Prev in Thread] Current Thread [Next in Thread>