Hi Martins,
----- Original Message -----
> [...]
> You can ignore all of this until I am done. I just wanted to get this
> out there since I don't know where in your cgroup work you are. I think
> the only conflict might be in proc_pid.c with my addition of an extra
> parameter into some of the existing methods as I mentioned before.
Ah - OK - thanks for getting it out. cgroups is progressing nicely, I'm
hoping end-of-this-week-ish it should be all revised. So far, the rework
and refactoring is proving a neat improvement.
>
> One thing I noticed and am trying to track down:
>
> In the:
>
> static void
> refresh_metrictable(pmdaMetric *source, pmdaMetric *dest, int id)
>
> callback that I provide. The domain doesn't appear to be set in the
> "source" at the time this call is made. I check, and it is "0". But
> everything seems to work. I assume this gets set at some later time?
Yeah, hmm, can't remember exactly how this works - but the domain number
usually gets stamped into the static metrictable at pmdaInit time. ISTR
some need to pass the domain number around, in order to stamp it into
the dynamic metric PMIDs as well ... but its a vague memory. This may be
an area where the dynamic metrics libpcp_pmda code could be improved too,
BTW - not sure, but keep that in mind (might be easier to pull the domain
number out of the pmdaExt structure and writing it into the source, if it
is missing at the time the callback is called? I don't think that could
harm any existing PMDA code)
cheers.
--
Nathan
|