pcp
[Top] [All Lists]

Re: [pcp] RFC: papi pmda auto-enable on fetch

To: Lukas Berk <lberk@xxxxxxxxxx>
Subject: Re: [pcp] RFC: papi pmda auto-enable on fetch
From: "Frank Ch. Eigler" <fche@xxxxxxxxxx>
Date: Mon, 3 Nov 2014 21:46:01 -0500
Cc: pcp developers <pcp@xxxxxxxxxxx>
Delivered-to: pcp@xxxxxxxxxxx
In-reply-to: <87k33b251j.fsf@xxxxxxxxxx>
References: <20141103210747.GB3859@xxxxxxxxxx> <87k33b251j.fsf@xxxxxxxxxx>
User-agent: Mutt/1.4.2.2i
Hi -

> Thanks for throwing this together.  I like the idea of using the
> timeout to ensure counters don't continue on for too long.  

No problemo.

> The only nit I have within the code itself; is there a chance you
> could give the 'auto_afid' variable a more descriptive name? [...]

Sure.

> If you would consider a few doc tweaks (patch attached) I'd appreciate
> it.  

Sure.  (Please feel free to commit such things straight to my branch.)

> I'd be nice if the pminfo help text labled the units for a quick
> glance without needing the man page.  [...]

In the case of the papi.control.auto_enable metric, I had that
addendum ("in seconds") there too at one point, but then realized that
the metric was already self-describing (pminfo -d -> Units: sec).

- FChE

<Prev in Thread] Current Thread [Next in Thread>