I've reviewed these Frank, and cherry-picked 'em into my tree.
qa/518 passes, but that does not prove much because I was not seeing any
failures with this test on my QA machines.
Reviewing the code, ... the second commit seems fine. I wonder about the
first one, as it seems killing -a pmie may produce collateral damage and
indeed on the one system I tried this a pmie instance that has nothing to do
with qa/518 was nuked. This does not seem right.
Do you have any additional information on the circumstances in which the
first kill does not cause the pmie process launched by qa/518 to exit?
Perhaps we need to try a bit harder to get the pid of the pmie process,
rather than the pid of the sudo shell?
> -----Original Message-----
> From: pcp-bounces@xxxxxxxxxxx [mailto:pcp-bounces@xxxxxxxxxxx] On
> Behalf Of Frank Ch. Eigler
> Sent: Saturday, 1 November 2014 7:13 AM
> To: pcp developers
> Subject: [pcp] qa/518 tweaks on pcpfans.git fche/dev
>
> Hi -
>
> Please consider these two ditties. They make the test case conclude
> successfully & reliably on my fedora-22 rawhide vm.
>
>
> Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
> Date: Fri Oct 31 16:03:37 2014 -0400
>
> qa/518: stretch timing to run more reliably
>
> This test case involves a race between pmie running rules a certain
> number of times, and a separate task waiting (by time) to match the
> results via /usr/bin/pcp. It was observed as flakey, not always
> winning the race. This version stretches the pmie time and fine-tunes
> the waiting interval to give the race a larger (multi-second) window
> for success.
>
> commit 808aad5a20cd3b29a9368e60aedf6bb92acc7521
> Author: Frank Ch. Eigler <fche@xxxxxxxxxx>
> Date: Fri Oct 31 16:02:03 2014 -0400
>
> qa/518:
>
> It was observed that the $sudo pmie invocation didn't always
> receive the closing signal at this test case, leading it to
> hang. Now we kill it harder, both by pid and later by name.
>
> _______________________________________________
> pcp mailing list
> pcp@xxxxxxxxxxx
> http://oss.sgi.com/mailman/listinfo/pcp
|