On 10/28/2014 04:40 PM, Nathan Scott wrote:
Hi guys,
----- Original Message -----
[...]
Thanks Mark, the patch works fine, I see the different values now.
Given how dynamic CPUs can be these days, it might be nice to
add the online/offline status (/sys/devices/system/cpu/cpu1/online)
as well.
Good idea - I'll hack that up tomorrow unless someone beats me to it.
that could be opening a nice big juicy can of worms - would we also
want the cpu instance domain to become dynamic? Or keep it how it
is with online and offline CPUs included?
The default logging here is "once" for hinv, so that might need tweaking as
well.
Yeah, hmmm, thats a bit awkward - I don't really want us to have to
explicitly list each hinv metric in the logging configs. Not sure
what else we can do though.
The 'atop-summary' logger config already includes it :
#+ tools/atop-summary:y:default:
## metrics sampled once by the atop command
log advisory on default {
hinv.cpu.clock
hinv.ncpu
mem.physmem
}
Regards
-- Mark
|