Re: [pcp] hinv.*

[Michele Baldessari <michele@xxxxxxxxxx>]

Hi Mark,

On Thu, Oct 23, 2014 at 10:09:40AM +1100, Mark Goodwin wrote:
> On 10/23/2014 04:40 AM, Nathan Scott wrote:
> >>while for most hinv.* metrics I do not expect any changes over time
> >>(hinv.pagesize, hinv.ncpu, ...), I was a bit surprised that also
> >>hinv.cpu.clock seems to not change over time (F21 updated today, here).
> 
> The original code was written before CPU clock throttling,
> cstates and so forth, and hence didn't expect the clock to
> change. It does nowdays! Attached patch should fix it (untested
> but should be fine). I'll also need to check if the default
> pmlogger config only logs hinv.cpu.clock once - that might
> need an update too, and of course some QA.

Thanks Mark, the patch works fine, I see the different values now.
Given how dynamic CPUs can be these days, it might be nice to
add the online/offline status (/sys/devices/system/cpu/cpu1/online)
as well.

The default logging here is "once" for hinv, so that might need tweaking as
well.

Cheers,
Michele
-- 
Michele Baldessari            <michele@xxxxxxxxxx>
C2A5 9DA3 9961 4FFB E01B  D0BC DDD4 DCCB 7515 5C6D