----- Original Message -----
> > They exposed bugs in the authentication mechanism, exercise the install
> > and remove mechanisms
>
> Only barely so (see below): and not the "remove" mechanisms (since there
> is nothing to remove from an -L blank slate).
>
You've misunderstood - as in, Install and Remove (scripts), which of
course is (shell) code, needing testing too.
> > As discussed awhile back, I added these tests as just a start on
> > testing, so that we had some basic initial coverage. So, please
> > leave these tests as-is and build on this base with new tests.
> > [...]
>
> Simply switching them from -L to the default -h would actually get a
> bit of new coverage of the core code. What's the disadvantage?
That could be done, your earlier mail advocated a more intrusive set
of changes though. However, it'd make test 914 significantly slower
(reducing its utility as a quick smoke test, & removing all coverage
of the DSO mode functionality) since...
If this conversion to -h is done, then the test will need to become
more like 903 where PMDA Install/Remove is performed - tests cannot
assume optional PMDAs are installed at the start, and need to clean
'em up at the end.
Writing new tests still seems a good way to go here, so either leave
these two as is, or extend 903 (which already has the install/remove
logic) with some fetch/store additions like 914.
cheers.
--
Nathan
|