Hi Martins,
----- Original Message -----
> > [...]
> > I've had time to go through the code in detail now - this looks like a
> > good step forward, and its much simpler than I expected.
> >
> Thanks for the review.
No problem.
> So if I understand you correctly, the {psinfo,id,memory,io,fd,
> schedstat} metrics become dynamic both in proc and hotproc? For
> implementation, the steps would be something like?:
>
> 1. Clean out root_proc of metrics we want to make dynamic
> 2. Replicate the logic from cgroups.c and adapt to [hot]proc to create
> these on the fly
> 3. Even though these are dynamic, we reuse existing cluster and id
> numbers so as not to confuse client tools.
Spot on, yes; keeping the existing PMIDs for those proc metrics that
become dynamic and making the hotproc variants just the same (but with
non-conflicting cluster IDs of course).
> It seems like the first step would be to convert the existing pmda to
> handle dynamic metrics for the appropriate clusters that already exist
> before we worry about hotproc?
Yep. I believe that will work nicely - of course there may be issues
I've not anticipated (lemme know early on, if so), but I'm pretty sure
that will work out well.
> Do you want me to have a go at that or do you have a specific plan in
> mind already?
It'd be great if you could take that on - please go right ahead.
cheers.
--
Nathan
|