On 07/10/14 17:44, Nathan Scott wrote:
> Hi Ken,
>
> ----- Original Message -----
>> qa/232 was failing on Centos 7.
>>
>> There are NR_RPC4_SVR_COUNTERS instances, numbered 1 (not 0) to
>> NR_RPC4_SVR_COUNTERS, but the values are stored in [0] ...
>> [NR_RPC4_SVR_COUNTERS-1] of proc_net_rpc->server.reqcounts4[].
>>
>> It would be _really_ good to have someone who knows the nfs code in the linux
>> pmda to review these changes, and if they are correct to check that similar
>> mismatches are not happening for the other nfs/rpc metrics.
>
> I recently spent several hours pouring over the NFS kernel code to
> get a handle on these metrics (adding the nfs4.1 ops support), as
> well as the userspace code in nfsstat(1). Is the test failing with
> latest dev? (its not failing here - can you send through the .bad
> file you saw? thanks!) Was this commit in place for this QA run:
>
> commit b690dcb8049963a6c7516cc5c89312dd9095840a
> Author: Nathan Scott <nathans@xxxxxxxxxx>
> Date: Fri Sep 26 10:44:01 2014 +1000
>
> Update qa/232 to handle recent nfs4.1 indom changes
>
>
> The odd non-zero indexing is a quirk of the NFS v4 code, and does
> not affect the earlier NFS variants. I was fairly confident that
> the pmdalinux code was correct when I left it, so I'm keen to get
> more of a handle on things from that .bad file.
first line of output below appears in 232.out.bad
but more telling is that the 59th member of the indom "[58] 59 reclaim_comp" is
not returned by pmFetch with no profile.
kenj@vm08:~/src/pcp/qa$ src/torture_indom -v nfs4.server.reqs
number of instances from unprofiled fetch (58) != that for pmGetInDom (59)
unprofiled fetch:
[0] 1 op0-unused
[1] 2 op1-unused
[2] 3 op2-future
[3] 4 access
[4] 5 close
[5] 6 commit
[6] 7 create
[7] 8 delegpurge
[8] 9 delegreturn
[9] 10 getattr
[10] 11 getfh
[11] 12 link
[12] 13 lock
[13] 14 lockt
[14] 15 locku
[15] 16 lookup
[16] 17 lookup_root
[17] 18 nverify
[18] 19 open
[19] 20 openattr
[20] 21 open_conf
[21] 22 open_dgrd
[22] 23 putfh
[23] 24 putpubfh
[24] 25 putrootfh
[25] 26 read
[26] 27 readdir
[27] 28 readlink
[28] 29 remove
[29] 30 rename
[30] 31 renew
[31] 32 restorefh
[32] 33 savefh
[33] 34 secinfo
[34] 35 setattr
[35] 36 setcltid
[36] 37 setcltidconf
[37] 38 verify
[38] 39 write
[39] 40 rellockowner
[40] 41 bc_ctl
[41] 42 bind_conn
[42] 43 exchange_id
[43] 44 create_ses
[44] 45 destroy_ses
[45] 46 free_stateid
[46] 47 getdirdeleg
[47] 48 getdevinfo
[48] 49 getdevlist
[49] 50 layoutcommit
[50] 51 layoutget
[51] 52 layoutreturn
[52] 53 secinfononam
[53] 54 sequence
[54] 55 set_ssv
[55] 56 test_stateid
[56] 57 want_deleg
[57] 58 destroy_clid
pmGetInDom:
[0] 1 op0-unused
[1] 2 op1-unused
[2] 3 op2-future
[3] 4 access
[4] 5 close
[5] 6 commit
[6] 7 create
[7] 8 delegpurge
[8] 9 delegreturn
[9] 10 getattr
[10] 11 getfh
[11] 12 link
[12] 13 lock
[13] 14 lockt
[14] 15 locku
[15] 16 lookup
[16] 17 lookup_root
[17] 18 nverify
[18] 19 open
[19] 20 openattr
[20] 21 open_conf
[21] 22 open_dgrd
[22] 23 putfh
[23] 24 putpubfh
[24] 25 putrootfh
[25] 26 read
[26] 27 readdir
[27] 28 readlink
[28] 29 remove
[29] 30 rename
[30] 31 renew
[31] 32 restorefh
[32] 33 savefh
[33] 34 secinfo
[34] 35 setattr
[35] 36 setcltid
[36] 37 setcltidconf
[37] 38 verify
[38] 39 write
[39] 40 rellockowner
[40] 41 bc_ctl
[41] 42 bind_conn
[42] 43 exchange_id
[43] 44 create_ses
[44] 45 destroy_ses
[45] 46 free_stateid
[46] 47 getdirdeleg
[47] 48 getdevinfo
[48] 49 getdevlist
[49] 50 layoutcommit
[50] 51 layoutget
[51] 52 layoutreturn
[52] 53 secinfononam
[53] 54 sequence
[54] 55 set_ssv
[55] 56 test_stateid
[56] 57 want_deleg
[57] 58 destroy_clid
[58] 59 reclaim_comp
|